-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stringref operations #2687
Conversation
With #2689 in place, instructions that technically accept but would throw when provided a |
There is some proof of concept code now, showing how |
Quick update: There has been a more general string discussion in CG context meanwhile. Iiuc, an alternative to
Translated: Our thing that intentionally does not address the thing should be off-label responsible for the thing so we can not address the thing and eventually the Web becomes the special case - it's |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions! |
This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions! |
This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards. |
Implements the current state of the Reference-Typed Strings proposal (currently phase 1) as supported by Binaryen, for now as built-ins to enable experimentation. A constant reference-typed string can be created using a string literal in a
ref_string
context.Enable with
--enable stringref
in AS,--experimental-wasm-stringref
in V8.✔️ Available ⏳ Available but incomplete ❌ Not available
Possible follow-up work in case there is interest: Populate the
RefString
wrapper class using the instructions to mimicString
, so it can eventually replaceString
. So far this PR implements a few string functions as a POC.