Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor useStakerInfo hook #664

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

sirius651
Copy link
Contributor

@sirius651 sirius651 commented Jan 12, 2023

Pull Request Summary

refactor useStakerInfo hook with v2 architecture .
related #662

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Visit the preview URL for this PR (updated for commit 8dd743e):

https://astar-apps--pr664-refactor-use-staker-2c480b7g.web.app

(expires Fri, 20 Jan 2023 07:47:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@sirius651 sirius651 marked this pull request as ready for review January 13, 2023 05:10
@sirius651
Copy link
Contributor Author

please review if this structure is feasible @impelcrypto @bobo-k2

Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I've fixed a minor issue in this PR. Please take a look.

@sirius651
Copy link
Contributor Author

LGTM
I've fixed a minor issue in this PR. Please take a look.

Great. I'll continue work on useUnbonding hook

@sirius651 sirius651 merged commit 8cc0fd6 into feat/dapps-staking-v2 Jan 13, 2023
@sirius651 sirius651 deleted the refactor/use-staker branch January 13, 2023 07:54
sirius651 added a commit that referenced this pull request Feb 8, 2023
…re (#662)

* feat: made a template structure for dapp-staking v2

* refactor: cleanup

* refactor useStakerInfo hook (#664)

* add getStakeInfo function in repo

* migrate getStake function to v2

* fix: modified fetching 'My staking information' logic when users change the account (#666)

Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>

* Refactor/unbonding hook (#670)

* diminish snowpack & put space on tvl text (#663)

* feat:Support for BNC and vDOT assets (#658)

* feat:Support for BNC and vDOT assets

* Fix some errors

* Update BifrostXcmRepository.ts

* Add some constants

* 0.0.9

* feat: updated japanese translation (#665)

* go back logo (#667)

* migrate for useUnbonding hook

Co-authored-by: NingBo Wang <2536935847@qq.com>
Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>

---------

Co-authored-by: Will <korea651@hanmail.net>
Co-authored-by: NingBo Wang <2536935847@qq.com>
Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants