feat: migrate business logic in dApp staking v2 to v2(new) architecture #662

impelcrypto · 2023-01-11T08:55:09Z

Pull Request Summary

feat: migrate business logic in dApp staking v2 to v2(new) architecture

Check list

Release notes:

feat: migrate business logic in dApp staking v2 to v2(new) architecture

This pull request makes the following changes:

Changes

(ex: Change document B)

github-actions · 2023-01-11T09:00:48Z

Visit the preview URL for this PR (updated for commit 80b1a9d):

https://astar-apps--pr662-feat-dapps-staking-v-5cnpdvye.web.app

_{(expires Tue, 14 Feb 2023 09:12:00 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db}

impelcrypto · 2023-01-11T09:15:58Z

src/hooks/useClaimAll.ts

    for (let i = 0; i < batchTxsRef.length; i++) {
      const tx = batchTxsRef[i];
+      console.log('tx.weight', tx.weight.toString());


Hi @bobo-k2
I found there is a breaking change in tx.weight because WeightV2(?) is coming. Could you help take a look at update the logic? We can't claim rewards on Shibuya now.

=Shibuya (WeightV2)=

=Astar/Shiden=

Sure, I will take a look

Fixed in #671

* add getStakeInfo function in repo * migrate getStake function to v2 * fix: modified fetching 'My staking information' logic when users change the account (#666) Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>

…rk/astar-apps into feat/dapps-staking-v2

* diminish snowpack & put space on tvl text (#663) * feat:Support for BNC and vDOT assets (#658) * feat:Support for BNC and vDOT assets * Fix some errors * Update BifrostXcmRepository.ts * Add some constants * 0.0.9 * feat: updated japanese translation (#665) * go back logo (#667) * migrate for useUnbonding hook Co-authored-by: NingBo Wang <2536935847@qq.com> Co-authored-by: github-actions <github-actions@users.noreply.github.com> Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>

…rk/astar-apps into feat/dapps-staking-v2

sirius651 · 2023-01-16T07:49:52Z

@impelcrypto @bobo-k2 Finished migrate for useUnbonding by following to useClaim. please review. and I just wondering isn't it the right direction to hide all calls related to api? It is used in both hooks and v2s, but what are the advantages of this?

bobo-k2 · 2023-01-16T08:03:34Z

@impelcrypto @bobo-k2 Finished migrate for useUnbonding by following to useClaim. please review. and I just wondering isn't it the right direction to hide all calls related to api? It is used in both hooks and v2s, but what are the advantages of this?

Main idea was to separate concerns so we can write unit tests and make code maintenance easier.. Eg. on Sub0 there were talks about Polkadot.js replacement. If sometimes in the future we decide to replace Polkadot.js, because of the better api we will need to change repositories only. The rest of the code should be fine.
I am open for discussion about UI architecture direction. We can have a call sometimes this week if needed.

impelcrypto · 2023-01-16T08:24:22Z

My Available to claim hasn't updated (without refresh the page) after the claiming transaction has been done. Let's take a look 🤔

sirius651 · 2023-01-17T05:38:14Z

My Available to claim hasn't updated (without refresh the page) after the claiming transaction has been done. Let's take a look 🤔

when I tried it on my end, it works well. @bobo-k2 can you reproduce this?

bobo-k2 · 2023-02-06T21:22:50Z

My Available to claim hasn't updated (without refresh the page) after the claiming transaction has been done. Let's take a look 🤔

when I tried it on my end, it works well. @bobo-k2 can you reproduce this?

It works on my side. Available to claim refreshes after Claim operation is performed

bobo-k2 · 2023-02-06T21:35:36Z

It looks like unbonding is not working for some dApps. Try the following on Shibuya:

click unbond (I tested with ADAO dApp)
enter amount and sign transaction
spinner will show
spinner will hide, but unbonding dialog stays opened and no unbonding performed.

I tried some other dApps and unbond without problem. Also noticed that Unbonding tab didn't show after successfull unbodning. I needed to refresh the the portal. I can't reproduce this anymore, but it is worth checking

impelcrypto · 2023-02-07T08:27:19Z

My Available to claim hasn't updated (without refresh the page) after the claiming transaction has been done. Let's take a look 🤔

@sirius651 @bobo-k2 It works properly now

…etwork/astar-apps into feat/dapps-staking-v2

impelcrypto · 2023-02-07T09:15:30Z

It looks like unbonding is not working for some dApps. Try the following on Shibuya:

@bobo-k2 @sirius651 I've fixed this issue. Please test it again.

sirius651

it works well for me

bobo-k2

LGTM

impelcrypto · 2023-02-07T15:28:41Z

@sirius651 You can merge this PR anytime :D

feat: made a template structure for dapp-staking v2

091eb09

impelcrypto mentioned this pull request Jan 11, 2023

Migrate business logic in dapp staking v2 to new architecture #656

Closed

6 tasks

impelcrypto assigned sirius651, bobo-k2 and impelcrypto Jan 11, 2023

refactor: cleanup

7701920

impelcrypto commented Jan 11, 2023

View reviewed changes

impelcrypto changed the title ~~feat: migrate business logic in dapp staking v2 to v2 architecture~~ feat: migrate business logic in dapp staking v2 to v2(new) architecture Jan 11, 2023

impelcrypto changed the title ~~feat: migrate business logic in dapp staking v2 to v2(new) architecture~~ feat: migrate business logic in dApp staking v2 to v2(new) architecture Jan 11, 2023

sirius651 mentioned this pull request Jan 12, 2023

refactor useStakerInfo hook #664

Merged

6 tasks

sirius651 and others added 6 commits January 13, 2023 16:54

refactor useStakerInfo hook (#664)

8cc0fd6

* add getStakeInfo function in repo * migrate getStake function to v2 * fix: modified fetching 'My staking information' logic when users change the account (#666) Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>

Merge branch 'main' into feat/dapps-staking-v2

303a3c2

Merge branch 'feat/dapps-staking-v2' of https://github.com/PlasmNetwo…

514d8d5

…rk/astar-apps into feat/dapps-staking-v2

Merge branch 'feat/dapps-staking-v2' of https://github.com/PlasmNetwo…

ab3e3ea

…rk/astar-apps into feat/dapps-staking-v2

Merge branch 'main' into feat/dapps-staking-v2

67a0823

impelcrypto requested a review from sirius651 January 16, 2023 08:06

impelcrypto marked this pull request as ready for review January 16, 2023 08:07

Merge branch 'main' into feat/dapps-staking-v2

6df3a6a

sirius651 added 2 commits January 25, 2023 10:56

Merge branch 'main' into feat/dapps-staking-v2

69e8554

Merge branch 'main' into feat/dapps-staking-v2

59bbad1

andabak requested a review from bobo-k2 January 31, 2023 12:12

fix: conflicts

ba3106d

impelcrypto added 2 commits February 7, 2023 18:04

fix: closes modals once clicks confirm

b1b4cb5

Merge branch 'feat/dapps-staking-v2' of github.com-impelcrypto:AstarN…

80b1a9d

…etwork/astar-apps into feat/dapps-staking-v2

sirius651 approved these changes Feb 7, 2023

View reviewed changes

bobo-k2 approved these changes Feb 7, 2023

View reviewed changes

sirius651 merged commit f087772 into main Feb 8, 2023

sirius651 deleted the feat/dapps-staking-v2 branch February 8, 2023 02:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate business logic in dApp staking v2 to v2(new) architecture #662

feat: migrate business logic in dApp staking v2 to v2(new) architecture #662

impelcrypto commented Jan 11, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2023 •

edited

Loading

impelcrypto Jan 11, 2023 •

edited

Loading

bobo-k2 Jan 12, 2023

bobo-k2 Feb 1, 2023

sirius651 commented Jan 16, 2023

bobo-k2 commented Jan 16, 2023

impelcrypto commented Jan 16, 2023 •

edited

Loading

sirius651 commented Jan 17, 2023

bobo-k2 commented Feb 6, 2023

bobo-k2 commented Feb 6, 2023

impelcrypto commented Feb 7, 2023

impelcrypto commented Feb 7, 2023

sirius651 left a comment

bobo-k2 left a comment

impelcrypto commented Feb 7, 2023

feat: migrate business logic in dApp staking v2 to v2(new) architecture #662

feat: migrate business logic in dApp staking v2 to v2(new) architecture #662

Conversation

impelcrypto commented Jan 11, 2023 • edited Loading

github-actions bot commented Jan 11, 2023 • edited Loading

impelcrypto Jan 11, 2023 • edited Loading

Choose a reason for hiding this comment

bobo-k2 Jan 12, 2023

Choose a reason for hiding this comment

bobo-k2 Feb 1, 2023

Choose a reason for hiding this comment

sirius651 commented Jan 16, 2023

bobo-k2 commented Jan 16, 2023

impelcrypto commented Jan 16, 2023 • edited Loading

sirius651 commented Jan 17, 2023

bobo-k2 commented Feb 6, 2023

bobo-k2 commented Feb 6, 2023

impelcrypto commented Feb 7, 2023

impelcrypto commented Feb 7, 2023

sirius651 left a comment

Choose a reason for hiding this comment

bobo-k2 left a comment

Choose a reason for hiding this comment

impelcrypto commented Feb 7, 2023

impelcrypto commented Jan 11, 2023 •

edited

Loading

github-actions bot commented Jan 11, 2023 •

edited

Loading

impelcrypto Jan 11, 2023 •

edited

Loading

impelcrypto commented Jan 16, 2023 •

edited

Loading