Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:Support for BNC and vDOT assets #658

Merged
merged 5 commits into from
Jan 12, 2023
Merged

feat:Support for BNC and vDOT assets #658

merged 5 commits into from
Jan 12, 2023

Conversation

hqwangningbo
Copy link
Contributor

Pull Request Summary

Support for BNC and vDOT assets

@impelcrypto
Copy link
Member

Hi @hqwangningbo
Thank you for your contribution. Kindly submit required subscan links and staging URL for testing. Thanks.
https://docs.astar.network/docs/xcm/integration/add-to-portal#requirements-for-creating-a-pr

@hqwangningbo
Copy link
Contributor Author

  1. ASTR
    transfer in : https://bifrost.subscan.io/xcm_message/polkadot-d0ec8a79ddd6618e14a4e1da4de7907895de66cc
    transfer out : https://bifrost.subscan.io/xcm_message/polkadot-219c208acc0c7fee1af2b011b528cf6a505fc4fb

  2. BNC
    transfer in : https://bifrost.subscan.io/xcm_message/polkadot-eb79d58dabcc8913aee4e40c63f2424c2a0c88e5
    transfer out : https://bifrost.subscan.io/xcm_message/polkadot-fcea6b8b56d86dea4b2688d9ccfcb8c3fc4f8c80

  3. vDOT
    transfer in : https://bifrost.subscan.io/xcm_message/polkadot-7e712740b456d71d63f85d8cd87e2c4566242f95
    transfer out : https://bifrost.subscan.io/xcm_message/polkadot-dca80e8305ffd85c55c447c9f1df43ffdabc4f0c

@impelcrypto
Copy link
Member

Thanks, could you deploy this branch to somewhere like Vercel? So that our team can test it.
https://docs.astar.network/docs/builder-guides/Integration%20and%20Toolings/deploy-astar-portal

@hqwangningbo
Copy link
Contributor Author

Our front end has just been successfully deployed, and the test link is here.
https://astar.test.liebi.com/#/astar/assets

@impelcrypto
Copy link
Member

thanks, could you send some BNC and vDOT to 5H6DC1YjyD531FiGxPCpWY3WNJrp5kQ35xHm6wibKuFvWzKW for testing? CC: @fiexer @bobo-k2 @sirius651 @Kahonnohak

@Kahonnohak
Copy link
Contributor

Happy to test too. 5C7jzpzLw5jEejupKCpKfu6dwcdG9M1Jhgz9htqPGx9GwXbN

@hqwangningbo
Copy link
Contributor Author

@impelcrypto @Kahonnohak Some related tokens have been transferred

@hqwangningbo hqwangningbo requested review from bobo-k2 and impelcrypto and removed request for sirius651, Kahonnohak and bobo-k2 January 10, 2023 16:20
@hqwangningbo
Copy link
Contributor Author

@bobo-k2 @impelcrypto I have edited

@Kahonnohak
Copy link
Contributor

Deposit and Withdraw to/from Astar Native/EVM were all successful!

@fiexer
Copy link
Member

fiexer commented Jan 11, 2023

Could we also add Shiden support in this PR?
We also have open channels on Kusama, would be great to include this in the release.

impelcrypto
impelcrypto approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bobo-k2
bobo-k2 approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@bobo-k2 bobo-k2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@impelcrypto impelcrypto merged commit 4d81d91 into AstarNetwork:main Jan 12, 2023
sirius651 added a commit that referenced this pull request Jan 16, 2023
@sirius651 @hqwangningbo @impelcrypto
Refactor/unbonding hook (#670)
58d0afa 
* diminish snowpack & put space on tvl text (#663)

* feat:Support for BNC and vDOT assets (#658)

* feat:Support for BNC and vDOT assets

* Fix some errors

* Update BifrostXcmRepository.ts

* Add some constants

* 0.0.9

* feat: updated japanese translation (#665)

* go back logo (#667)

* migrate for useUnbonding hook

Co-authored-by: NingBo Wang <2536935847@qq.com>
Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>
sirius651 added a commit that referenced this pull request Feb 8, 2023
@impelcrypto @sirius651 @hqwangningbo
feat: migrate business logic in dApp staking v2 to v2(new) architectu…
f087772 
…re (#662)

* feat: made a template structure for dapp-staking v2

* refactor: cleanup

* refactor useStakerInfo hook (#664)

* add getStakeInfo function in repo

* migrate getStake function to v2

* fix: modified fetching 'My staking information' logic when users change the account (#666)

Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>

* Refactor/unbonding hook (#670)

* diminish snowpack & put space on tvl text (#663)

* feat:Support for BNC and vDOT assets (#658)

* feat:Support for BNC and vDOT assets

* Fix some errors

* Update BifrostXcmRepository.ts

* Add some constants

* 0.0.9

* feat: updated japanese translation (#665)

* go back logo (#667)

* migrate for useUnbonding hook

Co-authored-by: NingBo Wang <2536935847@qq.com>
Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Co-authored-by: impelcrypto <92044428+impelcrypto@users.noreply.github.com>

---------

Co-authored-by: Will <korea651@hanmail.net>
Co-authored-by: NingBo Wang <2536935847@qq.com>
Co-authored-by: github-actions <github-actions@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobo-k2 bobo-k2 bobo-k2 approved these changes

@impelcrypto impelcrypto impelcrypto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hqwangningbo @impelcrypto @Kahonnohak @fiexer @bobo-k2