-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack): add laravel.nvim #1108
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
Just heads up, I updated the body of the PR to correctly link issues it closes |
My bad, I also added a last minute change noting the blade syntax highlighting |
The more i play around with this, I am noticing missing feature from other IDE's but there are plugins to bring them back. I'm gonna put this into draft so i can try and create a better out of the box experience for everyone |
@ALameLlama Feel free to ping me if you want a sparring partner. |
@Uzaaft That would be awesome, I've added https://github.com/Bleksak/laravel-ide-helper.nvim which is working great and I've tried to add https://github.com/RicardoRamirezR/blade-nav.nvim but I'm getting some error and i think some of these are pebcak
route cmp is dying https://github.com/RicardoRamirezR/blade-nav.nvim/blob/main/lua/blade-nav/utils.lua#L96 but other plugins are working https://github.com/Bleksak/laravel-ide-helper.nvim/blob/main/lua/laravel-ide-helper/helpers.lua#L15, Imma keep playing around with this since this might be a plugin issue using the goto file seems to blow up Using gf on a view
using gf on a route
I'll keep trying to resolve these myself, In an ideal world we could recreate https://laravel-idea.com/ within nvim 😅 edit: I've opened a PR to fix the route:list dying |
Those PR's have been merged, I'll keep playing around with things to see how if I spot anything else |
Looking into some test plugins for phpunit/pest and then I'll move this pr out of draft. That should cover enough to give a good experience for laravel devs |
Truly amazing attention to detail and work here. Thanks so much! Very much looking forward to getting this added in :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It is buggy!!! |
Cannot replicate @MrMic . Please take the extra time to really figure out what is happening with your local setup. My guess is you just have an old version of AstroCommunity |
Amazing work @ALameLlama, really appreciate it! |
Reinstall all and still got this error:
laravel-dev-generators and laravel-dev-tools are in my path. 🤔 |
Closes #1103
📑 Description
Add support for laravel.nvim with some mappings
ℹ Additional Information