-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(conform-nvim): fix formatters_by_ft definitions #1129
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
@lucazz I’m about to head to bed so I cant deep dive into it, but based upon the warning you have this seem wrong. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incorrect, all of them should be
{ "prettierd", "prettier", stop_after_first = true }
@lucazz Why did you add it to the places where it's not needed? |
Let me take those out, @Uzaaft I thought it wouldn't hurt to have them in place. hold on |
Danke Danke |
Alright, done and done :-) |
a290453
to
7745354
Compare
Co-authored-by: Micah Halter <micah@mehalter.com>
Co-authored-by: Micah Halter <micah@mehalter.com>
Co-authored-by: Micah Halter <micah@mehalter.com>
Co-authored-by: Micah Halter <micah@mehalter.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think this looks correct now, thanks! Just to clarify why the previous ones were incorrect. The nested structure indicated when to only stop at the first. The ones that were not previously nested indicated multiple formatters so we very much do not want them to stop at the first
📑 Description
As requested by @Uzaaft on #1127 #1128, I'm merging all changes in a single PR.
This PR updates stevearc/conform.nvim's setup, addressing the deprecation warning that comes up when opening any yaml file while using the yaml pack: