feat: fhir-qb-sql and unit tests for Sequelize/Postgres #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ported - Need to figure out exists and assembly out still
…tools into feat/fhir-qb-sql
Took out several tests because we have not implemented them yet: - search transformation (_count parameter) - pagination (we handle this on the server side) - exists not implemented
* feat: 100 percent code coverage * chore: update test descriptions and prettier
sshah-asymmetrik
requested review from
jonterrylee and
Robert-W
as code owners
zeevo
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] - not done yet! Do not merge.
Doing a sanity check.
EDIT via Sumeet: ready now.