Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of indexOf method, change default return value #11

Closed
Athari opened this issue Jun 9, 2015 · 0 comments
Closed

Improve performance of indexOf method, change default return value #11

Athari opened this issue Jun 9, 2015 · 0 comments
Assignees
@Athari
Labels
resolved:done Done type:improvement Improvement
Milestone
3.0

Comments

@Athari
Copy link
Owner

Athari commented Jun 9, 2015

Use array_search for indexOf when possible. Breaking change: array_search returns false when value isn't found, indexOf should too.

See #10 (Improve performance when working with arrays).
@Athari Athari added the type:improvement Improvement label Jun 9, 2015
@Athari Athari self-assigned this Jun 9, 2015
@Athari Athari added this to the 3.0 milestone Jun 9, 2015
Athari added a commit that referenced this issue Apr 16, 2018
@Athari
#11 (Improve performance of indexOf method, change default return val…
9025fe1 
…ue).
@Athari Athari added the resolved:done Done label Apr 16, 2018
@Athari Athari closed this as completed Apr 16, 2018
@Athari Athari mentioned this issue Sep 2, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Athari Athari

Labels
resolved:done Done type:improvement Improvement
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@Athari