Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when working with arrays #10

Closed
Athari opened this issue Jun 6, 2015 · 1 comment
Closed

Improve performance when working with arrays #10

Athari opened this issue Jun 6, 2015 · 1 comment
Assignees
Labels
Milestone

Comments

@Athari
Copy link
Owner

Athari commented Jun 6, 2015

Implementations of some methods can be replaced with a single call to built-in functions if underlying iterator is wrapping an array, for example toValues, toKeys, max etc. Use built-in functions whenever possible.

@Athari
Copy link
Owner Author

Athari commented Dec 2, 2021

After some testing, this feature turned out to be largely impossible without making users of the library use numerous predefined static lambdas, which becomes highly inconvenient in the light of planned removal of string lambdas. Where '$k' was possible, now Functions::$key would be required, instead of typical for the modern PHP fn($v, $k) => $k. So even if that feature is implemented, it'll be obscure for the vast majority of users and a tough sell for those who are aware.

As such, this feature is abandoned.

@Athari Athari closed this as completed Dec 2, 2021
@Athari Athari added the resolved:wontfix Won't fix label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant