Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name used in IC logs is inconsistent in certain cases #247

Closed
mposs00 opened this issue Aug 16, 2020 · 1 comment
Closed

Name used in IC logs is inconsistent in certain cases #247

mposs00 opened this issue Aug 16, 2020 · 1 comment
Assignees
Labels
bug Confirmed bug fix-available PR exists that may solve the issue ui Issues related to the user interface (non-viewport related)

Comments

@mposs00
Copy link
Contributor

mposs00 commented Aug 16, 2020

if the person sending the message is iniswapped and showname is disabled, the name printed in the logs will be the local client name
if the person sending the message is iniswapped and showname is enabled, and chatblank is enabled, then the logs will print the networked name

this is due to different variables used to set f_showname here https://github.com/AttorneyOnline/AO2-Client/blob/master/src/courtroom.cpp#L1797

example:
image

@mposs00 mposs00 changed the title Name used in IC logs is inconsistent Name used in IC logs is inconsistent in certain cases Aug 16, 2020
@mposs00 mposs00 added bug Confirmed bug ui Issues related to the user interface (non-viewport related) labels Aug 16, 2020
@mposs00
Copy link
Contributor Author

mposs00 commented Aug 16, 2020

confirmed by @Crystalwarrior

@mposs00 mposs00 self-assigned this Aug 16, 2020
@mposs00 mposs00 added the fix-available PR exists that may solve the issue label Aug 16, 2020
@mposs00 mposs00 closed this as completed Aug 16, 2020
@mposs00 mposs00 mentioned this issue Aug 17, 2020
11 tasks
lambdcalculus pushed a commit to lambdcalculus/AO2-Client that referenced this issue Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug fix-available PR exists that may solve the issue ui Issues related to the user interface (non-viewport related)
Projects
None yet
Development

No branches or pull requests

1 participant