2.8.5 #246
Merged
2.8.5 #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix not using custom chatbox's colors Moved set_text_color_dropdown() to after current_char is actually updated with the selected char. Otherwise set_text_color_dropdown will try to update the colors with either nothing as character, or with the previously selected character. Use get_chat() so it actually gets the name of the custom chatbox instead of using the same name as the character. Remove the extra "c" since get_chat_color it's already called with this "c" in place. * Fix previous fix crashing the client on DRO servers For some reason the client would work just fine if set_text_color_dropdown() was called only once after updating the character selected by the user. But when joining a DRO server the client would crash just before loading the music. * Improve comment with where crash happens * Fix get_chat_markdown to get the custom chatbox on misc of the char instead of trying to find the character folder on misc * Fix client using the current character colors on other people's messages Also remove the comment explaining the crash if set_text_color_dropdown is removed from set_widgets * Fix loading custom colors loading after the message was added to the log
Edited TL, added TL for tool tips and other untranslated strings. Courtroom UI elements were left in English to avoid cropping.
…ine constants for minimum and maximum packet sizes
Check for custom realization sound when using effects list
Optimize ARUP
Fix improper bolding behavior due to malformed string literal
Crystalwarrior
previously approved these changes
Aug 18, 2020
- Set lib as artifact instead of cache (to avoid race condition described in https://gitlab.com/gitlab-org/gitlab/-/issues/21409) - Delete _Unadapted folder and .git files when exporting artifact (yuck! should probably have never incorporated AO2-Themes as a separate repo; it should probably have stayed part of the vanilla repo.)
* Rewrite the IC Log code to drastically reduce code duplication and have both downward and upward mode in the same function Regenerate the IC Log in set_widgets() function, making sure the maximum_blocks is accounted for and clearing the log to prepare for different log mode (upwards/downwards) if it's different from previous Add placeholder text telling the user the direction in which the log will go Remove useless first_message_sent global boolean, a remnant from a w e a k e r c o d e r m a n * Add log_colors boolean to reduce color I/O happening in append_ic_text (optimization meme) Clear the IC log when log_colors setting changes and reload theme is pressed Fix #221 * Add configurable margin between IC log entries Add configurable newline/singleline log mode Options in settings for these * Add optional timestamps * Un-hardcode "played music" from the chatlogpiece and introduce the "action" argument so that "presented evidence" is fully supported now Translate "has presented evidence" Regenerate IC chatlog instead of clearing it, properly updating every element with the new configurations * Go away *temp, code duplication making me shid and cry rn Why is this not done in append_ic_text, or why isn't there a dedicated ic logging func aAAAaaaaAAAaa Fix presenting evidence not being properly logged Fix timestamp being UTC instead of local time (local time will not be as confusing) * okok it was a joke a big ol bamboozle you got gnomed haha rick rolled beaned stickbugged I did NOT copy paste code, no, I actually intended to fix copy pasted code all along. log_ic_text was always planned. (Fix copypasted code for ic_chatlog_history and consolidate it into a single log_ic_text func)
* Allow changing audio device on the fly while in a server * Use default audio device if device in config doesn't exist * Automatically change audio device to default when current one is invalid * Destroy Qt Multimedia support It was decided that there was not enough attention being given to Qt Multimedia support to justify its continued maintenance simply as a libre alternative to BASS. While substantial changes to audio were being made in 2.8, the Qt Multimedia support code fell behind in disrepair. It's clear that there is no vested interest in implementing audio features twice for the sake of licensing. When it's time to switch to another audio library, it will be done unilaterally. * CI: Use BASS for Linux build Co-authored-by: oldmud0 <oldmud0@users.noreply.github.com>
Most importantly, Linux now targets Qt 5.9.5 with a self-built version of QtApng, which should fix the Qt version issues.
| @@ -3,7 +3,7 @@ QT += core gui widgets network | |||
| TARGET = Attorney_Online | |||
| TEMPLATE = app | |||
|
|
|||
| VERSION = 2.8.4.0 | |||
| VERSION = 2.8.5.0 | |||
Crystalwarrior
previously approved these changes
Aug 20, 2020
There was a problem hiding this comment.
My review was kinda lazy so another reviewer like @oldmud0 should check if I missed anything slimy
Also, update the themes submodule pls
We don't want to accidentally overwrite players' server lists when performing trivial updates. (The launcher should remove the 'sample' qualifier when it is performing a full install, though that is not implemented right now and the move operation is sadly broken.)
Crystalwarrior
previously approved these changes
Aug 20, 2020
|
No issues on all platforms as far as I can see. I've ram multiple tests and even had confirmation from mac uses as well the new client is working fine. |
likeawindrammer
previously approved these changes
Aug 21, 2020
There was a problem hiding this comment.
No issues on all platforms as far as I can see. I've ram multiple tests and even had confirmation from mac uses as well the new client is working fine.
Same here testing with linux, the bass related changes work well, and the CI builds use ubuntu 18.04 as base again so hopefully there isn't any weird issues on non-ubuntu distros.
Crystalwarrior
previously approved these changes
Aug 21, 2020
likeawindrammer
dismissed stale reviews from Crystalwarrior and themself
via
af1e760
|
lgtm |
|
After evaluating, CI publish step isn't gonna work due to the switch to BunnyCDN. Maybe another day. |
oldmud0
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merge:
Tentative changelog:
Bugfixes
Changes
New features