Audio fixes #262
Merged
Audio fixes #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mposs00
commented
Aug 18, 2020
•
mposs00
commented
- Fixes Program does not correctly handle changing audio devices during runtime [Bass Audio] #257
- Fixes Qt audio backend is broken on Linux #263
update audio fixes branch
BASS improvements
|
Switching audio devices using the audio tab works At the very least there's a way to make it work by using the audio tab, though an automatic solution would be preferred EDIT: Behavior may be intedned, I don't have the speakers to check intended behavior |
Crystalwarrior
approved these changes
Aug 19, 2020
It was decided that there was not enough attention being given to Qt Multimedia support to justify its continued maintenance simply as a libre alternative to BASS. While substantial changes to audio were being made in 2.8, the Qt Multimedia support code fell behind in disrepair. It's clear that there is no vested interest in implementing audio features twice for the sake of licensing. When it's time to switch to another audio library, it will be done unilaterally.
mposs00
commented
Aug 19, 2020
| #else | ||
| const QString audio = "null"; | ||
| #endif | ||
| const bool hasApng = QImageReader::supportedImageFormats().contains("APNG"); |
There was a problem hiding this comment.
this is a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.