[C-924] Add fully native explore screen #1819

dylanjeffers · 2022-08-30T01:04:24Z

Description

Refactors explore screen use use purely native store

raymondjacobson

it's lit

raymondjacobson · 2022-08-30T01:07:26Z

packages/mobile/src/screens/collection-screen/CollectionScreenDetailsTile.tsx

+  const dispatch = useDispatch()
+
+  useEffect(() => {
+    dispatch(tracksActions.fetchLineupMetadatas(0, 200, false, undefined))


i know you copy pasta'd but gross

yeah gross indeed

raymondjacobson · 2022-08-30T01:07:41Z

packages/mobile/src/screens/explore-screen/ExploreScreen.tsx

  usePopToTopOnDrawerOpen()

+  useEffectOnce(() => {


such a great util

raymondjacobson · 2022-08-30T01:09:43Z

packages/mobile/src/screens/smart-collection-screen/SmartCollectionScreen.tsx


  const isSaved = playlistLibrary
    ? !!findInPlaylistLibrary(playlistLibrary, smartCollection.variant)
    : false

  const handlePressSave = useCallback(() => {
    if (collection?.has_current_user_saved) {
-      dispatchWeb(
+      dispatch(


mind confirming this works?

https://linear.app/audius/issue/C-831/[qa]-explore-playlists-not-saving-in-mobile

so guessing this won't work in this branch since none of the social sagas have been added. thinking we address that in a social actions pass soon?

Ah yes, sounds good

audius-infra · 2022-08-30T01:29:20Z

Preview this change https://demo.audius.co/dj-c-924-native-explore-screen

* [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) * Search results screen (#1782) * search results screen * remove comments Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * [C-902] Move collection page to native (#1798) * [C-903] Migrate feed to native store (#1799) * [React Native Reloaded] Make mobile search fully native (#1808) * search -> native * pr review * clean up after migrating search (#1809) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * [C-872] Play audio in native (#1807) * [C-778] Native notifications (#1810) * Remove /macro usage for typed-redux-saga (#1751) * Make resetting of badge count native * Split sagas between web and mobile * Update dispatch and selectors in notifs * [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) * Search results screen (#1782) * search results screen * remove comments Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Get notifications loading * [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) * Search results screen (#1782) * search results screen * remove comments Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * [C-902] Move collection page to native (#1798) * [C-903] Migrate feed to native store (#1799) * Delete unused mobileSagas * Remove uneeded notifications slice * Clean up notif message passing * [React Native Reloaded] Make mobile search fully native (#1808) * search -> native * pr review * clean up after migrating search (#1809) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Fix type issues * Lint fix Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: nicoback2 <36916764+nicoback2@users.noreply.github.com> * Update selectors and dispatches * [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) * Search results screen (#1782) * [C-902] Move collection page to native (#1798) * [C-903] Migrate feed to native store (#1799) * [React Native Reloaded] Make mobile search fully native (#1808) * [C-872] Play audio in native (#1807) * [C-778] Native notifications (#1810) * Remove /macro usage for typed-redux-saga (#1751) * Make resetting of badge count native * Split sagas between web and mobile * Update dispatch and selectors in notifs * [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) * Search results screen (#1782) * search results screen * remove comments Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Get notifications loading * [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) * Search results screen (#1782) * search results screen * remove comments Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * [C-902] Move collection page to native (#1798) * [C-903] Migrate feed to native store (#1799) * Delete unused mobileSagas * Remove uneeded notifications slice * Clean up notif message passing * [React Native Reloaded] Make mobile search fully native (#1808) * search -> native * pr review * clean up after migrating search (#1809) Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> * Fix type issues * Lint fix Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: nicoback2 <36916764+nicoback2@users.noreply.github.com> * [C-917] Add native trending screen (#1816) * [C-924] Add fully native explore screen (#1819) * [C-931] Fully native favorites screen (#1823) * [C-929] Add fully native drawers (#1824) * Fix blob error * Add profile sagas and fetch profile * Put useSelectProfile deps back for now * Get profile lineups working * Fix type * Revert tracks sagas * Fix path Co-authored-by: Dylan Jeffers <dylan@audius.co> Co-authored-by: Nikki Kang <kangaroo233@gmail.com> Co-authored-by: Raymond Jacobson <ray@audius.co> Co-authored-by: nicoback2 <36916764+nicoback2@users.noreply.github.com>

[f91506e] [C-1006] Improve initial load, hotfix missing web worker (#1896) Dylan Jeffers [edc8433] @audius/sdk@1.0.4 (#1892) Sebastian Klingler [bd9e726] [C-1003] Native Account Sagas (#1890) Sebastian Klingler [a0a202b] [C-958] Add native tip reaction (#1888) Dylan Jeffers [26ba05f] nativefy search results lineup (#1883) nicoback2 [c764096] [C-995] Remove message passing interfaces (#1886) Dylan Jeffers [98a563d] Fix trending-screen react warnings Dylan Jeffers [8f269fe] Fix merge conflicts Dylan Jeffers [257cf96] [C-991] Add native edit/delete playlists Dylan Jeffers [94c1343] [C-991] Add native create/edit playlists (#1882) Dylan Jeffers [35ff23c] [C-989] Add common track-download (#1880) Dylan Jeffers [6530fcb] [C-988] Fix social actions by fixing metro imports (#1875) Dylan Jeffers [3d8dbf9] [C-969] Add native audio-screen (#1873) Dylan Jeffers [3583795] Revert "Fix social features and other sig-util features (#1860)" Dylan Jeffers [8fe2291] Fix social features and other sig-util features (#1860) Dylan Jeffers [f93ce60] [C-967] Add native deactivate-account sagas (#1859) Dylan Jeffers [a793591] [C-965] Add native reset-password (#1858) Dylan Jeffers [54229a1] [C-962, C-904] Native recovery email (#1856) Dylan Jeffers [fc9410d] [C-953] Migrate profile supporters/supporting (#1855) Sebastian Klingler [27d5e00] [C-960] Add native push/email settings (#1854) Dylan Jeffers [6b7f1b0] [C-937] Refactor theme state, Implement native theme (#1851) Dylan Jeffers [fe149be] [C-955] Fully native settings screen (#1848) Dylan Jeffers [f60e001] Split up sign-out saga to web and native (#1847) Dylan Jeffers [24fc9b7] Add vipDiscordModal sagas Dylan Jeffers [09892f9] [C-927] Move sign up to native (#1820) Raymond Jacobson [eab6785] Migrate collectible details (#1839) Sebastian Klingler [0b79b90] [C-916] Native Profile Screen (#1834) Sebastian Klingler [f3eba19] [C-936] Remove WebView from native (#1831) sliptype [b80f930] [C-934] Add fully native user lists (#1830) sliptype [ec23451] [C-933] Add fully native social actions (#1825) sliptype [d49fa7c] Oops (#1828) Sebastian Klingler [5ae32b2] [C-929] Add fully native drawers (#1824) Dylan Jeffers [577ebf3] [C-931] Fully native favorites screen (#1823) Dylan Jeffers [7e143dd] [C-924] Add fully native explore screen (#1819) sliptype [69f7fe5] [C-917] Add native trending screen (#1816) Dylan Jeffers [5699349] [C-778] Native notifications (#1810) sliptype [5d8be85] [C-872] Play audio in native (#1807) sliptype [3e8f9a5] [React Native Reloaded] Make mobile search fully native (#1808) sliptype [44046ce] [C-903] Migrate feed to native store (#1799) Dylan Jeffers [eb3a714] [C-902] Move collection page to native (#1798) sliptype [ec25739] Search results screen (#1782) sliptype [b3394ca] [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) Dylan Jeffers [17f65ef] [C-974] Migrate account sagas (#1884) Sebastian Klingler [40bda4c] Fix optimizely for local dev (#1874) Michael Piazza [a3e62e8] Use bulk tracks from API client (#1849) Raymond Jacobson [643cbc5] Remove duplicate create user bank on sign up (#1868) Raymond Jacobson [7ec8f17] [C-868] Remove IPFS from client build steps (#1876) Raymond Jacobson [9ac5410] [C-878] Show invalid file errors on upload (#1877) Raymond Jacobson [369660f] Fixes profile pictures in top supporters tile (#1879) Reed [95c1392] Update feed tip tile per QA feedback (#1872) Reed [3f32abc] [PAY-600][PAY-599][PAY-607][PAY-617] RemoteConfig for Buy Audio and better transactiondetails link (#1861) Marcus Pasell [35393b5] Fix profile left nav tile spacing and order (#1871) Saliou Diallo [0297699] Revert "Fix optimizely local dev (#1261)" (#1870) Michael Piazza [67b97dd] Clean up remote-config init handlers (#1866) Sebastian Klingler [0806eed] [C-914] Fix windows build (#1867) Raymond Jacobson [965f9c0] [C-879] Fix rewards page navigation (#1865) Dylan Jeffers [9361232] Fix send $AUDIO flow after wallet saga migration (#1864) Reed [670e142] fix dark mode follows you (#1863) nicoback2 [3c2e178] Fix optimizely local dev (#1261) Michael Piazza [f133c0b] Adjust badge sizes and alignment (#1862) Sebastian Klingler

[C-924] Add native explore screen

b4835f6

pull-request-size bot added the size/XXL label Aug 30, 2022

dylanjeffers force-pushed the native-reloaded branch from 0d7d2aa to 6240ca9 Compare August 30, 2022 01:04

dylanjeffers requested review from sliptype and raymondjacobson August 30, 2022 01:05

raymondjacobson approved these changes Aug 30, 2022

View reviewed changes

fix web type for native

a588485

pull-request-size bot added size/L and removed size/XXL labels Aug 30, 2022

dylanjeffers merged commit e3f690c into native-reloaded Aug 30, 2022

dylanjeffers deleted the dj-c-924-native-explore-screen branch August 30, 2022 05:46

dylanjeffers added a commit that referenced this pull request Aug 30, 2022

[C-924] Add fully native explore screen (#1819)

e613e48

raymondjacobson pushed a commit that referenced this pull request Aug 30, 2022

[C-924] Add fully native explore screen (#1819)

66f591e

sliptype pushed a commit that referenced this pull request Aug 30, 2022

[C-924] Add fully native explore screen (#1819)

16ec208

dylanjeffers added a commit that referenced this pull request Aug 31, 2022

[C-924] Add fully native explore screen (#1819)

b5f53ba

dylanjeffers added a commit that referenced this pull request Sep 1, 2022

[C-924] Add fully native explore screen (#1819)

dd58051

sliptype added a commit that referenced this pull request Sep 2, 2022

[C-924] Add fully native explore screen (#1819)

1527a5c

sliptype added a commit that referenced this pull request Sep 2, 2022

[C-924] Add fully native explore screen (#1819)

14d576d

dylanjeffers pushed a commit that referenced this pull request Sep 9, 2022

[C-924] Add fully native explore screen (#1819)

7a77470

sliptype added a commit that referenced this pull request Sep 9, 2022

[C-924] Add fully native explore screen (#1819)

7e143dd

AudiusProject deleted a comment from linear bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-924] Add fully native explore screen #1819

[C-924] Add fully native explore screen #1819

dylanjeffers commented Aug 30, 2022

raymondjacobson left a comment

raymondjacobson Aug 30, 2022

dylanjeffers Aug 30, 2022

raymondjacobson Aug 30, 2022

raymondjacobson Aug 30, 2022

dylanjeffers Aug 30, 2022

raymondjacobson Aug 30, 2022

audius-infra commented Aug 30, 2022

[C-924] Add fully native explore screen #1819

[C-924] Add fully native explore screen #1819

Conversation

dylanjeffers commented Aug 30, 2022

Description

raymondjacobson left a comment

Choose a reason for hiding this comment

raymondjacobson Aug 30, 2022

Choose a reason for hiding this comment

dylanjeffers Aug 30, 2022

Choose a reason for hiding this comment

raymondjacobson Aug 30, 2022

Choose a reason for hiding this comment

raymondjacobson Aug 30, 2022

Choose a reason for hiding this comment

dylanjeffers Aug 30, 2022

Choose a reason for hiding this comment

raymondjacobson Aug 30, 2022

Choose a reason for hiding this comment

audius-infra commented Aug 30, 2022