[C-936] Remove WebView from native #1831

dylanjeffers · 2022-08-31T01:17:18Z

Description

Removes WebView from native
Updates useSelectorWeb to throw error (this will help us convert the rest of the app)
Fixes happy path to not throw useSelectorWeb error

Runs without the web app running!

Dragons

Splash screen behavior has been removed, so we will need to figure out best way to re-integrate
Im halfway through removing the native-mobile-interface on web as well, so happy to add that to this pr, or do in a followup

raymondjacobson

im sure this will break many a thing, but all for merging it

raymondjacobson · 2022-08-31T01:19:10Z

packages/mobile/ios/AudiusReactNative/Info.plist

@@ -1,104 +1,104 @@
 <?xml version="1.0" encoding="UTF-8"?>


what's up with the info.plist change?

yeah it's just my editor auto-formatting. i hade to update version so we didnt get the "updateRequired" stuff

but happy to revert the auto-format, and just modify the one line

this is fine w/ me

raymondjacobson · 2022-08-31T01:19:22Z

packages/mobile/package.json

@@ -106,7 +106,6 @@
    "react-native-screens": "3.13.0",
    "react-native-scrypt": "1.2.1",
    "react-native-shadow-2": "6.0.1",
-    "react-native-static-server": "github:futurepress/react-native-static-server.git#034c04e7a2999ae11a799fb68266c94389fc61bf",


raymondjacobson · 2022-08-31T01:22:11Z

packages/mobile/src/hooks/useKeyboardListeners.ts

@@ -1,37 +0,0 @@
-import type { RefObject } from 'react'


we could have probably dropped this after the native UI. nice

audius-infra · 2022-08-31T01:32:36Z

Preview this change https://demo.audius.co/dj-c-936-remove-webview-from-native

sliptype

FREAKING SWEET!!!

Let's think through the splash screen stuff, if we can get the skeletons displaying immediately after the splash that would be ideal

sliptype · 2022-08-31T01:23:34Z

packages/mobile/src/Drawers.tsx

@@ -117,7 +116,6 @@ export const Drawers = () => {
          drawer={Drawer}
        />
      ))}
-      <DiscordDrawer />


Why remove this?

yeah made a note, let me go back and double check, but it was basically rendering before the store was avail? maybe that selector hasn't been added come to think of it. basically ill try to get it "working" but ideally we move it in line with our other drawers :)

sliptype · 2022-08-31T01:27:22Z

packages/mobile/src/hooks/useDispatchWeb.ts

-    },
-    [webRef]
-  )
+  return useCallback((_action: { type: string; [key: string]: any }) => {


sliptype · 2022-08-31T01:27:58Z

packages/mobile/src/hooks/useUpdateRequired.ts

@@ -7,6 +7,7 @@ import { useRemoteVar } from 'app/hooks/useRemoteConfig'
 export const useUpdateRequired = () => {
  const { appVersion } = VersionNumber
  const minAppVersion = useRemoteVar(StringKeys.MIN_APP_VERSION)
+  console.log({ appVersion, minAppVersion })


no nice, this is what i used to realize we were falling behind with app verison :D

sliptype · 2022-08-31T01:30:45Z

packages/mobile/src/screens/signon/SignOn.tsx

@@ -339,8 +339,6 @@ const SignOn = ({ navigation }: SignOnProps) => {

  const isKeyboardOpen = useSelector(getIsKeyboardOpen)

-  // TODO: Remove when fully on react native store
-  const dappLoaded = useSelector(getDappLoaded)
  const lifecycleSignIn = useSelector(getIsSignedIn)


We can probably get this from the account slice instead

so thinking we don't even need right? this screen will only load when "notSignedIn" is true in AppScreen, at which point we can immediately run the sign-on screen animations since we have libs ready to go right away?

Oh yup makes sense

audius-infra · 2022-08-31T01:52:16Z

Preview this change https://demo.audius.co/dj-c-936-remove-webview-from-native

[f91506e] [C-1006] Improve initial load, hotfix missing web worker (#1896) Dylan Jeffers [edc8433] @audius/sdk@1.0.4 (#1892) Sebastian Klingler [bd9e726] [C-1003] Native Account Sagas (#1890) Sebastian Klingler [a0a202b] [C-958] Add native tip reaction (#1888) Dylan Jeffers [26ba05f] nativefy search results lineup (#1883) nicoback2 [c764096] [C-995] Remove message passing interfaces (#1886) Dylan Jeffers [98a563d] Fix trending-screen react warnings Dylan Jeffers [8f269fe] Fix merge conflicts Dylan Jeffers [257cf96] [C-991] Add native edit/delete playlists Dylan Jeffers [94c1343] [C-991] Add native create/edit playlists (#1882) Dylan Jeffers [35ff23c] [C-989] Add common track-download (#1880) Dylan Jeffers [6530fcb] [C-988] Fix social actions by fixing metro imports (#1875) Dylan Jeffers [3d8dbf9] [C-969] Add native audio-screen (#1873) Dylan Jeffers [3583795] Revert "Fix social features and other sig-util features (#1860)" Dylan Jeffers [8fe2291] Fix social features and other sig-util features (#1860) Dylan Jeffers [f93ce60] [C-967] Add native deactivate-account sagas (#1859) Dylan Jeffers [a793591] [C-965] Add native reset-password (#1858) Dylan Jeffers [54229a1] [C-962, C-904] Native recovery email (#1856) Dylan Jeffers [fc9410d] [C-953] Migrate profile supporters/supporting (#1855) Sebastian Klingler [27d5e00] [C-960] Add native push/email settings (#1854) Dylan Jeffers [6b7f1b0] [C-937] Refactor theme state, Implement native theme (#1851) Dylan Jeffers [fe149be] [C-955] Fully native settings screen (#1848) Dylan Jeffers [f60e001] Split up sign-out saga to web and native (#1847) Dylan Jeffers [24fc9b7] Add vipDiscordModal sagas Dylan Jeffers [09892f9] [C-927] Move sign up to native (#1820) Raymond Jacobson [eab6785] Migrate collectible details (#1839) Sebastian Klingler [0b79b90] [C-916] Native Profile Screen (#1834) Sebastian Klingler [f3eba19] [C-936] Remove WebView from native (#1831) sliptype [b80f930] [C-934] Add fully native user lists (#1830) sliptype [ec23451] [C-933] Add fully native social actions (#1825) sliptype [d49fa7c] Oops (#1828) Sebastian Klingler [5ae32b2] [C-929] Add fully native drawers (#1824) Dylan Jeffers [577ebf3] [C-931] Fully native favorites screen (#1823) Dylan Jeffers [7e143dd] [C-924] Add fully native explore screen (#1819) sliptype [69f7fe5] [C-917] Add native trending screen (#1816) Dylan Jeffers [5699349] [C-778] Native notifications (#1810) sliptype [5d8be85] [C-872] Play audio in native (#1807) sliptype [3e8f9a5] [React Native Reloaded] Make mobile search fully native (#1808) sliptype [44046ce] [C-903] Migrate feed to native store (#1799) Dylan Jeffers [eb3a714] [C-902] Move collection page to native (#1798) sliptype [ec25739] Search results screen (#1782) sliptype [b3394ca] [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) Dylan Jeffers [17f65ef] [C-974] Migrate account sagas (#1884) Sebastian Klingler [40bda4c] Fix optimizely for local dev (#1874) Michael Piazza [a3e62e8] Use bulk tracks from API client (#1849) Raymond Jacobson [643cbc5] Remove duplicate create user bank on sign up (#1868) Raymond Jacobson [7ec8f17] [C-868] Remove IPFS from client build steps (#1876) Raymond Jacobson [9ac5410] [C-878] Show invalid file errors on upload (#1877) Raymond Jacobson [369660f] Fixes profile pictures in top supporters tile (#1879) Reed [95c1392] Update feed tip tile per QA feedback (#1872) Reed [3f32abc] [PAY-600][PAY-599][PAY-607][PAY-617] RemoteConfig for Buy Audio and better transactiondetails link (#1861) Marcus Pasell [35393b5] Fix profile left nav tile spacing and order (#1871) Saliou Diallo [0297699] Revert "Fix optimizely local dev (#1261)" (#1870) Michael Piazza [67b97dd] Clean up remote-config init handlers (#1866) Sebastian Klingler [0806eed] [C-914] Fix windows build (#1867) Raymond Jacobson [965f9c0] [C-879] Fix rewards page navigation (#1865) Dylan Jeffers [9361232] Fix send $AUDIO flow after wallet saga migration (#1864) Reed [670e142] fix dark mode follows you (#1863) nicoback2 [3c2e178] Fix optimizely local dev (#1261) Michael Piazza [f133c0b] Adjust badge sizes and alignment (#1862) Sebastian Klingler

pull-request-size bot added the size/XXL label Aug 31, 2022

dylanjeffers changed the base branch from main to native-reloaded August 31, 2022 01:17

dylanjeffers requested review from sliptype and raymondjacobson August 31, 2022 01:17

raymondjacobson approved these changes Aug 31, 2022

View reviewed changes

dylanjeffers force-pushed the native-reloaded branch from 037311d to 33545ec Compare August 31, 2022 01:26

sliptype approved these changes Aug 31, 2022

View reviewed changes

dylanjeffers added 2 commits August 30, 2022 18:35

[C-936] Remove webview from native

8b809c0

Remove a lot more stuff

a9f8d37

dylanjeffers force-pushed the dj-c-936-remove-webview-from-native branch from 932e597 to a9f8d37 Compare August 31, 2022 01:35

dylanjeffers added 2 commits August 30, 2022 18:52

Remove more webRef stuff

a0eb77f

final fixes!

b636cdc

dylanjeffers merged commit 49a102d into native-reloaded Aug 31, 2022

dylanjeffers deleted the dj-c-936-remove-webview-from-native branch August 31, 2022 01:56

dylanjeffers added a commit that referenced this pull request Sep 1, 2022

[C-936] Remove WebView from native (#1831)

f0b2ef5

sliptype added a commit that referenced this pull request Sep 2, 2022

[C-936] Remove WebView from native (#1831)

55987b4

sliptype added a commit that referenced this pull request Sep 2, 2022

[C-936] Remove WebView from native (#1831)

ba99ce6

dylanjeffers pushed a commit that referenced this pull request Sep 9, 2022

[C-936] Remove WebView from native (#1831)

5bcb73e

sliptype added a commit that referenced this pull request Sep 9, 2022

[C-936] Remove WebView from native (#1831)

f3eba19

AudiusProject deleted a comment from linear bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-936] Remove WebView from native #1831

[C-936] Remove WebView from native #1831

dylanjeffers commented Aug 31, 2022 •

edited

raymondjacobson left a comment

raymondjacobson Aug 31, 2022

dylanjeffers Aug 31, 2022

dylanjeffers Aug 31, 2022

raymondjacobson Aug 31, 2022

raymondjacobson Aug 31, 2022

raymondjacobson Aug 31, 2022

audius-infra commented Aug 31, 2022

sliptype left a comment

sliptype Aug 31, 2022

dylanjeffers Aug 31, 2022

sliptype Aug 31, 2022

sliptype Aug 31, 2022

dylanjeffers Aug 31, 2022

sliptype Aug 31, 2022

dylanjeffers Aug 31, 2022

sliptype Aug 31, 2022

audius-infra commented Aug 31, 2022

[C-936] Remove WebView from native #1831

[C-936] Remove WebView from native #1831

Conversation

dylanjeffers commented Aug 31, 2022 • edited

Description

Dragons

raymondjacobson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audius-infra commented Aug 31, 2022

sliptype left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audius-infra commented Aug 31, 2022

dylanjeffers commented Aug 31, 2022 •

edited