-
Notifications
You must be signed in to change notification settings - Fork 44
Conversation
wow!! woot!!! will do more thorough review later but is music confetti something that we want in mobile? |
sg! maybe it's something we want in future? but yeah it's moved to common and simply has no saga attached in mobile :) found that easier than doing a IS_MOBILE check, dunno :D |
Preview this change https://demo.audius.co/dj-c-969-audio-screen |
Preview this change https://demo.audius.co/dj-c-969-audio-screen |
@@ -224,23 +224,23 @@ export const AudioScreen = () => { | |||
) | |||
} | |||
|
|||
const onPressSend = useCallback(() => { | |||
dispatchWeb( | |||
const handlePressSend = useCallback(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, should we standardize on handle
instead of on
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo yeah! it's fairly minor nit i have tho
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me. client sync that ish
@@ -36,5 +37,6 @@ export const storeContext: CommonStoreContext = { | |||
metadataProgramId: Config.METADATA_PROGRAM_ID | |||
}), | |||
// Shim in main, but defined in native-reloaded branch | |||
audioPlayer | |||
audioPlayer, | |||
cognito |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, the cognito stuff can probably be totally omitted (especially from mobile)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh good to know, well it's there :D
[f91506e] [C-1006] Improve initial load, hotfix missing web worker (#1896) Dylan Jeffers [edc8433] @audius/sdk@1.0.4 (#1892) Sebastian Klingler [bd9e726] [C-1003] Native Account Sagas (#1890) Sebastian Klingler [a0a202b] [C-958] Add native tip reaction (#1888) Dylan Jeffers [26ba05f] nativefy search results lineup (#1883) nicoback2 [c764096] [C-995] Remove message passing interfaces (#1886) Dylan Jeffers [98a563d] Fix trending-screen react warnings Dylan Jeffers [8f269fe] Fix merge conflicts Dylan Jeffers [257cf96] [C-991] Add native edit/delete playlists Dylan Jeffers [94c1343] [C-991] Add native create/edit playlists (#1882) Dylan Jeffers [35ff23c] [C-989] Add common track-download (#1880) Dylan Jeffers [6530fcb] [C-988] Fix social actions by fixing metro imports (#1875) Dylan Jeffers [3d8dbf9] [C-969] Add native audio-screen (#1873) Dylan Jeffers [3583795] Revert "Fix social features and other sig-util features (#1860)" Dylan Jeffers [8fe2291] Fix social features and other sig-util features (#1860) Dylan Jeffers [f93ce60] [C-967] Add native deactivate-account sagas (#1859) Dylan Jeffers [a793591] [C-965] Add native reset-password (#1858) Dylan Jeffers [54229a1] [C-962, C-904] Native recovery email (#1856) Dylan Jeffers [fc9410d] [C-953] Migrate profile supporters/supporting (#1855) Sebastian Klingler [27d5e00] [C-960] Add native push/email settings (#1854) Dylan Jeffers [6b7f1b0] [C-937] Refactor theme state, Implement native theme (#1851) Dylan Jeffers [fe149be] [C-955] Fully native settings screen (#1848) Dylan Jeffers [f60e001] Split up sign-out saga to web and native (#1847) Dylan Jeffers [24fc9b7] Add vipDiscordModal sagas Dylan Jeffers [09892f9] [C-927] Move sign up to native (#1820) Raymond Jacobson [eab6785] Migrate collectible details (#1839) Sebastian Klingler [0b79b90] [C-916] Native Profile Screen (#1834) Sebastian Klingler [f3eba19] [C-936] Remove WebView from native (#1831) sliptype [b80f930] [C-934] Add fully native user lists (#1830) sliptype [ec23451] [C-933] Add fully native social actions (#1825) sliptype [d49fa7c] Oops (#1828) Sebastian Klingler [5ae32b2] [C-929] Add fully native drawers (#1824) Dylan Jeffers [577ebf3] [C-931] Fully native favorites screen (#1823) Dylan Jeffers [7e143dd] [C-924] Add fully native explore screen (#1819) sliptype [69f7fe5] [C-917] Add native trending screen (#1816) Dylan Jeffers [5699349] [C-778] Native notifications (#1810) sliptype [5d8be85] [C-872] Play audio in native (#1807) sliptype [3e8f9a5] [React Native Reloaded] Make mobile search fully native (#1808) sliptype [44046ce] [C-903] Migrate feed to native store (#1799) Dylan Jeffers [eb3a714] [C-902] Move collection page to native (#1798) sliptype [ec25739] Search results screen (#1782) sliptype [b3394ca] [C-858] Add track page sagas to native, Refactor TrackScreen (#1768) Dylan Jeffers [17f65ef] [C-974] Migrate account sagas (#1884) Sebastian Klingler [40bda4c] Fix optimizely for local dev (#1874) Michael Piazza [a3e62e8] Use bulk tracks from API client (#1849) Raymond Jacobson [643cbc5] Remove duplicate create user bank on sign up (#1868) Raymond Jacobson [7ec8f17] [C-868] Remove IPFS from client build steps (#1876) Raymond Jacobson [9ac5410] [C-878] Show invalid file errors on upload (#1877) Raymond Jacobson [369660f] Fixes profile pictures in top supporters tile (#1879) Reed [95c1392] Update feed tip tile per QA feedback (#1872) Reed [3f32abc] [PAY-600][PAY-599][PAY-607][PAY-617] RemoteConfig for Buy Audio and better transactiondetails link (#1861) Marcus Pasell [35393b5] Fix profile left nav tile spacing and order (#1871) Saliou Diallo [0297699] Revert "Fix optimizely local dev (#1261)" (#1870) Michael Piazza [67b97dd] Clean up remote-config init handlers (#1866) Sebastian Klingler [0806eed] [C-914] Fix windows build (#1867) Raymond Jacobson [965f9c0] [C-879] Fix rewards page navigation (#1865) Dylan Jeffers [9361232] Fix send $AUDIO flow after wallet saga migration (#1864) Reed [670e142] fix dark mode follows you (#1863) nicoback2 [3c2e178] Fix optimizely local dev (#1261) Michael Piazza [f133c0b] Adjust badge sizes and alignment (#1862) Sebastian Klingler
Description
Adds native audio-screen
Migrates audio-rewards sagas to common
Migrates token-dashboard sagas to common
Migrates music confetti to common
Migrates Cognito to sagaContext