Support rewards challenge fields #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
changed the title
jowlee
reviewed
Jul 13, 2021
jowlee
reviewed
Jul 13, 2021
jowlee
previously approved these changes
Jul 13, 2021
raymondjacobson
force-pushed
the
rj-rewards-challenge-fields
branch
from
cfd70b2
to
14d0321
Compare
|
@piazzatron PTAL again when you've got a sec since I touched some challenges stuff being the only two commits of interest |
raymondjacobson
force-pushed
the
rj-rewards-challenge-fields
branch
from
e27ea20
to
f5d82b6
Compare
piazzatron
approved these changes
Jul 14, 2021
dmanjunath
added a commit
that referenced
this pull request
Jul 15, 2021
Bugfix Discovery undisbursed endpoint for rewards (#1642) * Add undisbursed challenges endpoint * Fix lint in discovery * Add undisbursed endpoint route * Fix limit and endpoint name * Addressed comments * Fix lint * Rebase changes * Update discovery test around fixture * Pass through arg * Address comments * Remove unused imports lint Support rewards challenge fields (#1636) * Support UserEvents in discovery indexing * Support referrer and is_mobile_user in libs * Add events to tasks metadata * Address comments * Fix misc type issues * Remove unused imports * Fix get_attestation type bug * Fix lint * Update down revision Debugging Debugging Circle config update config Debug Debug Debug Consolidate some logic Consolidate some logic Final cleanup + polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this PR? What is the current behavior? New behavior? Relevant links (e.g. Trello) and/or information pertaining to PR?
Add UserEvents table in discovery node to support indexing event fields off of user metadata.
Add support for two events,
referrerandis_mobile_userto support rewards challenge types.Tests
List the manual tests and repro instructions to verify that this PR works as anticipated. Include log analysis if possible.
❗ If this change impacts clients, make sure that you have tested the clients ❗
...
❗ Reminder 💡❗:
If this PR touches a critical flow (such as Indexing, Uploads, Gateway or the Filesystem), make sure to add the
requires-special-attentionlabel. Add relevant labels as necessary.How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
No immediate API impact, block diff on indexing would be the only thing to take note of as this gets released