Discovery undisbursed endpoint for rewards #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowlee
added
the
discovery-node
piazzatron
reviewed
Jul 13, 2021
| ns = Namespace("challenges", description="Challenge related operations") | ||
|
|
||
| get_undisbursed_challenges_route_parser = reqparse.RequestParser() | ||
| get_undisbursed_challenges_route_parser.add_argument("limit", required=False, type=int) |
There was a problem hiding this comment.
thoughts about if having offset would be useful as well?
There was a problem hiding this comment.
Yeah, we can add it, but I think cursor (keyset) base pagination might be more resilient?
For reference, this currently uses completed_blocknumber as the pseudo offset, but maybe we should add another field for offset - will do.
The things I'm worried about is if we add an offset and the challenges are being disbursed as we go, we could potentially skip challenges b/c of the offset.
There was a problem hiding this comment.
totally missed completed_blocknumber. makes sense
jowlee
force-pushed
the
jowlee-disc-undisbursed
branch
from
6ccc3e6
to
9623905
Compare
piazzatron
previously approved these changes
Jul 14, 2021
dmanjunath
added a commit
that referenced
this pull request
Jul 15, 2021
Bugfix Discovery undisbursed endpoint for rewards (#1642) * Add undisbursed challenges endpoint * Fix lint in discovery * Add undisbursed endpoint route * Fix limit and endpoint name * Addressed comments * Fix lint * Rebase changes * Update discovery test around fixture * Pass through arg * Address comments * Remove unused imports lint Support rewards challenge fields (#1636) * Support UserEvents in discovery indexing * Support referrer and is_mobile_user in libs * Add events to tasks metadata * Address comments * Fix misc type issues * Remove unused imports * Fix get_attestation type bug * Fix lint * Update down revision Debugging Debugging Circle config update config Debug Debug Debug Consolidate some logic Consolidate some logic Final cleanup + polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
/v1/challenges/undisbursedendpoint for discoveryTests
Wrote tests for the query
How will this change be monitored?
it will not be
Closes AUD-718