PLAT-339: add filter arg to top parser #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecsavvy
added
bug
raymondjacobson
approved these changes
Jan 23, 2023
stereosteve
approved these changes
Jan 24, 2023
alecsavvy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When anyone goes to the "Let Them DJ" page the same results are given for any user. The correct behavior is that this list is made up of playlists from the followees of the user requesting the page. If you unfollow any of the accounts on the page itself you will see they still show up after a refresh.
This fix makes the filter param available in the downstream query. Previously this was non-existent and falling into the "None" case every time.
Tests
I still need to learn how to write API level tests, stay tuned for tomorrow 馃檭
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
I don't think so. People will see that their "Let Them DJ" page change to reflect who they follow.