Fix top playlists with user_id #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowlee
commented
Feb 1, 2023
| @@ -44,7 +50,7 @@ def get_top_playlists(kind: TopPlaylistKind, args: GetTopPlaylistsArgs): | |||
| limit = args.get("limit", 16) | |||
| mood = args.get("mood", None) | |||
|
|
|||
| if "filter" in args: | |||
| if args.get("filter") is not None: | |||
There was a problem hiding this comment.
@alecsavvy Note that this broke in #4655 after the filter was added as a url param - causing it to pass in as None if not specified in the url param which then errored on the subsequent lines 55-56
There was a problem hiding this comment.
oh i see the difference, thanks!
stereosteve
approved these changes
Feb 2, 2023
jowlee
added a commit
that referenced
this pull request
Feb 2, 2023
jowlee
added a commit
that referenced
this pull request
Feb 2, 2023
audius-infra
pushed a commit
that referenced
this pull request
Feb 4, 2023
## Changelog - 2023-02-03 [5fa6731] Remove user bank from sdk signup (#4719) [Raymond Jacobson] - 2023-02-03 [5b9edbb] NO-TICKET: fix link for template generation in SDK (#4718) [Alec Savvy] - 2023-02-02 [4016364] Fix top playlists with user_id (#4701) [Joseph Lee] - 2023-01-30 [af22669] PLAT-623: death to the jdk (#4682) [Alec Savvy] - 2023-01-25 [2d36d63] SDK: Don't fail healthcheck on 0 blockdiff (#4670) [Marcus Pasell] - 2023-01-25 [894048c] Bump sdk to v1.0.43 [audius-infra]
audius-infra
pushed a commit
that referenced
this pull request
Feb 4, 2023
## Changelog - 2023-02-03 [5fa6731] Remove user bank from sdk signup (#4719) [Raymond Jacobson] - 2023-02-03 [5b9edbb] NO-TICKET: fix link for template generation in SDK (#4718) [Alec Savvy] - 2023-02-02 [4016364] Fix top playlists with user_id (#4701) [Joseph Lee] - 2023-01-30 [af22669] PLAT-623: death to the jdk (#4682) [Alec Savvy] - 2023-01-25 [2d36d63] SDK: Don't fail healthcheck on 0 blockdiff (#4670) [Marcus Pasell] - 2023-01-25 [894048c] Bump sdk to v1.0.43 [audius-infra]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the discovery endpoint /v1/full/playlists/top to accept an encoded user_id
Update the get_top_playlists query to not break on a none filter arg
Update the get_top_playlists query to accept a user_id param in the arg - falling back to the legacy fetching of user_id from x-user-id as an interim backup to not break existing clients
Updates libs binding for this endpoint to allow the user_id param
Tests
Ran libs linked locally and checked that the request was made with the correct parameter
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?