[C-4316, C-4317] SSR work to render webplayer and track page for web #8268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
Kyle-Shanks
commented
Apr 29, 2024
| @@ -3,7 +3,7 @@ import type { full } from '@audius/sdk' | |||
| import { AudiusQueryContextType, createApi } from '~/audius-query' | |||
| import { UserCollectionMetadata } from '~/models/Collection' | |||
| import { Kind } from '~/models/Kind' | |||
| import { makeActivity } from '~/services/audius-api-client/ResponseAdapter' | |||
| import { makeActivity } from '~/services/audius-api-client' | |||
There was a problem hiding this comment.
split out bc it pulls in sdk
Kyle-Shanks
commented
Apr 29, 2024
Comment on lines
+89
to
+90
| {/* {isMobile && <TopLevelPage />} */} | ||
| {/* {isMobile && <HeaderContextConsumer />} */} |
There was a problem hiding this comment.
Not needed yet, but will be needed later for web mobile track page
Kyle-Shanks
commented
Apr 29, 2024
| const ServerCoverPhoto = ({ className }: CoverPhotoProps) => { | ||
| return ( | ||
| <div className={cn(styles.coverPhoto, className)}> | ||
| {/* TODO: Add static image here */} |
There was a problem hiding this comment.
We don't render cover photos on the server side, so this is placeholder until whenever that work is done
Kyle-Shanks
commented
Apr 29, 2024
packages/web/src/components/repost-favorites-stats/RepostFavoritesStats.tsx
Outdated
Show resolved
Hide resolved
Kyle-Shanks
commented
Apr 29, 2024
| isMobile, | ||
| ...other | ||
| }: ServerTrackPageProps) => { | ||
| // return isMobile ? <MobilePage {...other} /> : <DesktopPage {...other} /> |
There was a problem hiding this comment.
placeholder for the web mobile track page work
Kyle-Shanks
commented
Apr 29, 2024
| streamConditions={defaults.streamConditions} | ||
| isDownloadGated={defaults.isDownloadGated} | ||
| downloadConditions={defaults.downloadConditions} | ||
| // TODO: fix this |
There was a problem hiding this comment.
will look into this
Kyle-Shanks
commented
Apr 29, 2024
sliptype
approved these changes
Apr 29, 2024
| popover?: boolean | ||
| } | ||
|
|
||
| // NOTE: Can't use user badges or user cache selectors bc it pulls in libs |
packages/web/src/components/repost-favorites-stats/RepostFavoritesStats.tsx
Outdated
Show resolved
Hide resolved
packages/web/src/pages/server-track-page/desktop/ServerTrackPage.module.css
Outdated
Show resolved
Hide resolved
| @@ -23,7 +23,7 @@ const HYDRATE_CLIENT = true | |||
|
|
|||
| export default async function render( | |||
| pageContext: PageContextClient & { | |||
| pageProps: { track: FullSdk.TrackFull } | |||
| pageProps: Pick<SsrPageProps, 'track'> | |||
Kyle-Shanks
force-pushed
the
kj-SSR-bundle-testing
branch
2 times, most recently
from
befea5f
to
7d62bf8
Compare
Kyle-Shanks
force-pushed
the
kj-SSR-bundle-testing
branch
from
7d62bf8
to
0ab28c3
Compare
|
Preview this change https://demo.audius.co/kj-SSR-bundle-testing |
audius-infra
pushed a commit
that referenced
this pull request
May 4, 2024
[9f44712] Reapply "Convert swagger.json to OAS 3.0 before generating SDK types (#8274)" (#8324) (#8344) Marcus Pasell [2ea74f3] Fix issues with text-link variant (#8343) Dylan Jeffers [f005b25] [PAY-2860] SDK Services Config - Configure SDK using environment (#8329) Marcus Pasell [11a0813] Disable add to playlist for prem tracks if not purchased (#8336) Reed [33b1916] [C-4335] Migrate all user and collection cards (#8338) Dylan Jeffers [dafaa21] [QA-1241] Fix hidden track add to playlist allowing non hidden items (#8340) JD Francis [4c95031] [QA-956] Add deleted tile for tracks/albums/playlists (#8333) JD Francis [b8f5990] Add error message to upload flow (#8334) JD Francis [22894e8] [QA-957] Fix android overflowing text on access & sale modal (#8313) JD Francis [86f6447] [PAY-2812] Change spend to earn challenge copy (#8332) Reed [d4c4264] Close modal on done (#8331) Saliou Diallo [ded4933] [PAY-2861] CollectionCard fixes (#8330) Dylan Jeffers [36277cd] Revert "Convert swagger.json to OAS 3.0 before generating SDK types (#8274)" (#8324) Marcus Pasell [146b2e0] [QA-1212] Fix chromecast (#8323) Raymond Jacobson [0b33e68] [PAY-2738] Public album with prem track always shows buy button (#8321) Reed [d897a98] [C-4333] Migrate follow-users to new sign-up flow (#8312) Dylan Jeffers [3129a3a] [PAY-2799] Show preview button for collections (#8271) Reed [8c58601] Modify /etc/hosts on CI machines before api test (#8319) Danny [3586f41] [PAY-2859] Fix bugs in edit app flow (#8320) Raymond Jacobson [1bf3e97] [PAY-2801] Purchased selectable filter in library albums (#8318) Reed [6db35c6] [C-4285] Add claim all rewards button functionality (#8292) Saliou Diallo [a20d85a] [PAY-2728] Implement edit app flow (#8256) Raymond Jacobson [714a3d1] [C-4288] Migrate to new cards in profile, search, and library (#8300) Dylan Jeffers [4dceb61] Upgrade dapp-store to 0.8.1 (#8311) Dylan Jeffers [4d37233] [PAY-2794] Use UserLink for purchases/sales tables (#8306) Reed [fc2aef3] [PAY-2772] Fix collection description text size (#8309) Reed [c35bfe1] [PAY-2822] Convert LockedContentDetailsTile to Harmony (#8308) Reed [f7a921e] [PAY-2781] Poll for track access on album purchase (#8296) Reed [621c3ee] Convert swagger.json to OAS 3.0 before generating SDK types (#8274) Marcus Pasell [09789c1] Retrigger logic for android notification permissions post-manifest fix (#8305) JD Francis [b9c042a] [PAY-2815] Show unlocked icon if dm content is purchased (#8303) Andrew Mendelsohn [722e933] [PAY-2779] Fix validation for albumTrackPrice (#8302) Andrew Mendelsohn [963bec4] Fix EditCollection playwright test (#8304) Andrew Mendelsohn [7e0aa7e] [PAY-2823] Edit Album access control fixes (#8298) Andrew Mendelsohn [b42b6fd] [QA-971] Fix smart collections (#8299) Raymond Jacobson [eceb876] [PAY-2791] Show only own albums in artist dashboard (#8297) Reed [87ce027] [Web] [Harmony] Add accounts managing you modal [C-4295] [C-4292] (#8258) nicoback2 [7a3567c] [C-4238, C-4318] Add ssr small bundle flow for mobile track page (#8293) Kyle Shanks [c7c3752] [PAY-2800] Fix mobile navigate to album on purchase success (#8295) Reed [f113a91] [PAY-2802] Auto-favorite tracks in purchased album (#8294) Reed [d32934f] [C-4284] Fix rewards in mobile web (#8291) Saliou Diallo [45c4bc6] [PAY-2775] Remove suggested tracks for albums (#8288) Andrew Mendelsohn [22280c6] [C-4080] Mobile cooldown and claim all (#8263) Isaac Solo [80cca19] Jail broken test (#8289) Raymond Jacobson [d7c8e34] [PAY-2766] Analytics events for premium albums (#8262) JD Francis [c3ee4a8] [PAY-2817] Web collections show reposts, remove artist column (#8272) Reed [6f8bab6] Fix lint items (#8285) Raymond Jacobson [e8debc0] [PAY-2703] Redesign mobile collection and track screen tiles (#8255) Andrew Mendelsohn [a3964a8] Bump android build number for release-client-v1.5.78 (#8286) Raymond Jacobson [8481f8d] [C-4327] Fix track ordering within playlist/album (#8284) Raymond Jacobson [5165172] Bump android version for manifest changes (#8283) JD Francis [4e60f97] [C-4312] Add UserCard (#8276) Dylan Jeffers [35ed4ec] [ONC-82] Fix android notif permissions (#8279) JD Francis [82e1c67] [C-4323] Improve Avatar (#8273) Dylan Jeffers [909db7c] [C-4316, C-4317] SSR work to render webplayer and track page for web (#8268) Kyle Shanks [7417a40] Generate sdk after ursm code removal (#8275) Raymond Jacobson [62b5a08] Update Add Funds copy and loading state (#8266) Saliou Diallo [4503cc7] PROTO-1328: always default to discovery relay (#8247) alecsavvy [f42c6cd] Fix text-input spacing (#8270) Dylan Jeffers [75fd847] [C-4270] Fix text-link transition (#8260) Dylan Jeffers [df0349a] [PAY-2761] Add managed users endpoints (#8238) Randy Schott [5b4c998] [ONC-84] Add try/catch (#8264) Raymond Jacobson [2b5f89c] Fix clipped text in TracksTable name column (#8265) Reed [c3256fa] [C-4275] Add google-inspectiontool to crawler regex (#8261) Sebastian Klingler [5750045] [C-4033] Prevent useTabs from redirecting on page load (#8259) Sebastian Klingler [b17ff70] [PAY-2758] Allow gated tracks to be added to playlists (#8227) Reed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work to render the app from the root all the way to the track page on the web side
Lots of updates here so I'll probably go through the PR and add some comments
How Has This Been Tested?
Lots of testing, bundle size analysis, and in app checking