Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAY-2823] Edit Album access control fixes #8298

Merged
merged 4 commits into from
May 2, 2024
Merged

[PAY-2823] Edit Album access control fixes #8298

merged 4 commits into from
May 2, 2024

Conversation

amendelsohn
Copy link
Contributor

Description

  • Hidden albums were showing as Public in the form initial values
  • Editing hidden album to premium wasn't working
  • Populate splits for albums changed to premium
  • Disable publishing of albums with hidden tracks

Screenshots

How Has This Been Tested?

working on local web

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 1, 2024 •
edited

⚠️ No Changeset found

Latest commit: 229c5a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

amendelsohn
amendelsohn commented May 1, 2024
View reviewed changes
packages/discovery-provider/src/tasks/entity_manager/entities/playlist.py
Comment on lines +400 to +402
if existing_playlist.get("is_private"):
# private playlist can be changed to gated or public
return
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is to allow indexing for playlists moving from hidden to gated/premium

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/am-PAY-2823

dharit-tan
dharit-tan approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@dharit-tan dharit-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/am-PAY-2823

@audius-infra
Copy link
Collaborator

Preview this change https://demo.audius.co/am-PAY-2823

@amendelsohn amendelsohn merged commit 7e0aa7e into main May 2, 2024
24 of 25 checks passed
@amendelsohn amendelsohn deleted the am-PAY-2823 branch May 2, 2024 00:09
audius-infra pushed a commit that referenced this pull request May 2, 2024
Audius Protocol v0.6.94
7abff7e 
[4abc13b] [PAY-2810] Purchase/Sale email fix text for albums (#8310) Reed
[992cf7d] [PAY-2764] Implement DeveloperApp Update entity manager action (#8254) Raymond Jacobson
[621c3ee] Convert swagger.json to OAS 3.0 before generating SDK types (#8274) Marcus Pasell
[7e0aa7e] [PAY-2823] Edit Album access control fixes (#8298) Andrew Mendelsohn
[8f7394c] ddex: parse contributors (#8267) Steve Perkins
[8520ee6] [PAY-2796] Fix extra notifications on track removal from purchased album (#8282) Reed
schottra added a commit that referenced this pull request May 2, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2722-account-swit…
0b82657 
…cher

* origin/main: (47 commits)
  [PAY-2728] Implement edit app flow (#8256)
  Audius Protocol v0.6.94
  [C-4288] Migrate to new cards in profile, search, and library (#8300)
  Upgrade dapp-store to 0.8.1 (#8311)
  [PAY-2794] Use UserLink for purchases/sales tables (#8306)
  [PAY-2810] Purchase/Sale email fix text for albums (#8310)
  [PAY-2764] Implement DeveloperApp Update entity manager action (#8254)
  [PAY-2772] Fix collection description text size (#8309)
  [PAY-2822] Convert LockedContentDetailsTile to Harmony (#8308)
  [PAY-2781] Poll for track access on album purchase (#8296)
  Convert swagger.json to OAS 3.0 before generating SDK types (#8274)
  Retrigger logic for android notification permissions post-manifest fix (#8305)
  [PAY-2815] Show unlocked icon if dm content is purchased (#8303)
  [PAY-2779] Fix validation for albumTrackPrice (#8302)
  Fix EditCollection playwright test (#8304)
  [PAY-2823] Edit Album access control fixes (#8298)
  [QA-971] Fix smart collections (#8299)
  [PAY-2791] Show only own albums in artist dashboard (#8297)
  [Web] [Harmony] Add accounts managing you modal [C-4295] [C-4292] (#8258)
  [C-4238, C-4318] Add ssr small bundle flow for mobile track page (#8293)
  ...
audius-infra pushed a commit that referenced this pull request May 4, 2024
Audius Client (Web and Mobile) v1.5.79
a78462b 
[9f44712] Reapply "Convert swagger.json to OAS 3.0 before generating SDK types (#8274)" (#8324) (#8344) Marcus Pasell
[2ea74f3] Fix issues with text-link variant (#8343) Dylan Jeffers
[f005b25] [PAY-2860] SDK Services Config - Configure SDK using environment (#8329) Marcus Pasell
[11a0813] Disable add to playlist for prem tracks if not purchased (#8336) Reed
[33b1916] [C-4335] Migrate all user and collection cards (#8338) Dylan Jeffers
[dafaa21] [QA-1241] Fix hidden track add to playlist allowing non hidden items (#8340) JD Francis
[4c95031] [QA-956] Add deleted tile for tracks/albums/playlists (#8333) JD Francis
[b8f5990] Add error message to upload flow (#8334) JD Francis
[22894e8] [QA-957] Fix android overflowing text on access & sale modal (#8313) JD Francis
[86f6447] [PAY-2812] Change spend to earn challenge copy (#8332) Reed
[d4c4264] Close modal on done (#8331) Saliou Diallo
[ded4933] [PAY-2861] CollectionCard fixes (#8330) Dylan Jeffers
[36277cd] Revert "Convert swagger.json to OAS 3.0 before generating SDK types (#8274)" (#8324) Marcus Pasell
[146b2e0] [QA-1212] Fix chromecast (#8323) Raymond Jacobson
[0b33e68] [PAY-2738] Public album with prem track always shows buy button (#8321) Reed
[d897a98] [C-4333] Migrate follow-users to new sign-up flow (#8312) Dylan Jeffers
[3129a3a] [PAY-2799] Show preview button for collections (#8271) Reed
[8c58601] Modify /etc/hosts on CI machines before api test (#8319) Danny
[3586f41] [PAY-2859] Fix bugs in edit app flow (#8320) Raymond Jacobson
[1bf3e97] [PAY-2801] Purchased selectable filter in library albums (#8318) Reed
[6db35c6] [C-4285] Add claim all rewards button functionality (#8292) Saliou Diallo
[a20d85a] [PAY-2728] Implement edit app flow (#8256) Raymond Jacobson
[714a3d1] [C-4288] Migrate to new cards in profile, search, and library (#8300) Dylan Jeffers
[4dceb61] Upgrade dapp-store to 0.8.1 (#8311) Dylan Jeffers
[4d37233] [PAY-2794] Use UserLink for purchases/sales tables (#8306) Reed
[fc2aef3] [PAY-2772] Fix collection description text size (#8309) Reed
[c35bfe1] [PAY-2822] Convert LockedContentDetailsTile to Harmony (#8308) Reed
[f7a921e] [PAY-2781] Poll for track access on album purchase (#8296) Reed
[621c3ee] Convert swagger.json to OAS 3.0 before generating SDK types (#8274) Marcus Pasell
[09789c1] Retrigger logic for android notification permissions post-manifest fix (#8305) JD Francis
[b9c042a] [PAY-2815] Show unlocked icon if dm content is purchased (#8303) Andrew Mendelsohn
[722e933] [PAY-2779] Fix validation for albumTrackPrice (#8302) Andrew Mendelsohn
[963bec4] Fix EditCollection playwright test (#8304) Andrew Mendelsohn
[7e0aa7e] [PAY-2823] Edit Album access control fixes (#8298) Andrew Mendelsohn
[b42b6fd] [QA-971] Fix smart collections (#8299) Raymond Jacobson
[eceb876] [PAY-2791] Show only own albums in artist dashboard (#8297) Reed
[87ce027] [Web] [Harmony] Add accounts managing you modal [C-4295] [C-4292] (#8258) nicoback2
[7a3567c] [C-4238, C-4318] Add ssr small bundle flow for mobile track page (#8293) Kyle Shanks
[c7c3752] [PAY-2800] Fix mobile navigate to album on purchase success (#8295) Reed
[f113a91] [PAY-2802] Auto-favorite tracks in purchased album (#8294) Reed
[d32934f] [C-4284] Fix rewards in mobile web (#8291) Saliou Diallo
[45c4bc6] [PAY-2775] Remove suggested tracks for albums (#8288) Andrew Mendelsohn
[22280c6] [C-4080] Mobile cooldown and claim all (#8263) Isaac Solo
[80cca19] Jail broken test (#8289) Raymond Jacobson
[d7c8e34] [PAY-2766] Analytics events for premium albums (#8262) JD Francis
[c3ee4a8] [PAY-2817] Web collections show reposts, remove artist column (#8272) Reed
[6f8bab6] Fix lint items (#8285) Raymond Jacobson
[e8debc0] [PAY-2703] Redesign mobile collection and track screen tiles (#8255) Andrew Mendelsohn
[a3964a8] Bump android build number for release-client-v1.5.78 (#8286) Raymond Jacobson
[8481f8d] [C-4327] Fix track ordering within playlist/album (#8284) Raymond Jacobson
[5165172] Bump android version for manifest changes (#8283) JD Francis
[4e60f97] [C-4312] Add UserCard (#8276) Dylan Jeffers
[35ed4ec] [ONC-82] Fix android notif permissions (#8279) JD Francis
[82e1c67] [C-4323] Improve Avatar (#8273) Dylan Jeffers
[909db7c] [C-4316, C-4317] SSR work to render webplayer and track page for web (#8268) Kyle Shanks
[7417a40] Generate sdk after ursm code removal (#8275) Raymond Jacobson
[62b5a08] Update Add Funds copy and loading state (#8266) Saliou Diallo
[4503cc7] PROTO-1328: always default to discovery relay (#8247) alecsavvy
[f42c6cd] Fix text-input spacing (#8270) Dylan Jeffers
[75fd847] [C-4270] Fix text-link transition (#8260) Dylan Jeffers
[df0349a] [PAY-2761] Add managed users endpoints (#8238) Randy Schott
[5b4c998] [ONC-84] Add try/catch (#8264) Raymond Jacobson
[2b5f89c] Fix clipped text in TracksTable name column (#8265) Reed
[c3256fa] [C-4275] Add google-inspectiontool to crawler regex (#8261) Sebastian Klingler
[5750045] [C-4033] Prevent useTabs from redirecting on page load (#8259) Sebastian Klingler
[b17ff70] [PAY-2758] Allow gated tracks to be added to playlists (#8227) Reed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharit-tan dharit-tan dharit-tan approved these changes

@DejayJD DejayJD Awaiting requested review from DejayJD

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amendelsohn @audius-infra @dharit-tan