[PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() #8278

rickyrombo · 2024-04-30T20:08:50Z

Description

Adds support for purchasing stream access to tracks using the SDK.

Currently defaults to using the user's userbank (if exists) unless a wallet adapter is passed to the method.

How Has This Been Tested?

Tested locally with new audius-cmd purchase-track

changeset-bot · 2024-04-30T20:08:53Z

🦋 Changeset detected

Latest commit: f6769b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@audius/sdk	Minor
@audius/spl	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

audius-infra · 2024-04-30T20:25:58Z

Preview this change https://demo.audius.co/mjp-sdk-purchase-access

gitguardian · 2024-05-02T01:20:13Z

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
4714545	Triggered	Generic High Entropy Secret	`bb5d992`	packages/libs/src/sdk/config/development.ts	View secret
10622417	Triggered	Generic High Entropy Secret	`bb5d992`	packages/libs/src/sdk/config/development.ts	View secret
1606950	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/production.ts	View secret
2416685	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/staging.ts	View secret
2460750	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/production.ts	View secret
4714545	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/development.ts	View secret
7150224	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/staging.ts	View secret
10622416	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/staging.ts	View secret
10622416	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/production.ts	View secret
10622417	Triggered	Generic High Entropy Secret	`679a5b9`	packages/libs/src/sdk/config/development.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-05-06T22:49:18Z

Preview this change https://demo.audius.co/mjp-sdk-purchase-access

…8345)

audius-infra · 2024-05-06T23:33:55Z

Preview this change https://demo.audius.co/mjp-sdk-purchase-access

raymondjacobson

huge if true

packages/commands/src/purchase-content.mjs

packages/commands/src/utils.mjs

packages/libs/src/sdk/api/tracks/TracksApi.ts

packages/libs/src/sdk/services/Solana/programs/PaymentRouterClient/PaymentRouterClient.ts

packages/spl/src/payment-router/PaymentRouterProgram.ts

audius-infra · 2024-05-07T01:03:58Z

Preview this change https://demo.audius.co/mjp-sdk-purchase-access

audius-infra · 2024-05-07T01:29:10Z

Preview this change https://demo.audius.co/mjp-sdk-purchase-access

schottra

Big lift!
No major complaints, just a lot of musings.

schottra · 2024-05-07T15:04:57Z

packages/commands/src/utils.mjs

+      middleware: [
+        {
+          pre: async (context) => {
+            const endpoint = 'http://audius-protocol-discovery-provider-1'


nit: Do we use any kind of env var or programmatic generation of this we could leverage? Feels like an easy way to get frustrated if something happens to change or you're running multiple DNs locally.

open to ideas - ideally this is temporary until we use relays broadly across nodes

Don't have any good recommendations at the moment, just wanted to call it out in case you did! 😄

packages/discovery-provider/src/api/v1/models/tracks.py

packages/discovery-provider/src/api/v1/models/users.py

schottra · 2024-05-07T15:08:53Z

packages/discovery-provider/src/api/v1/tracks.py

@@ -150,7 +150,7 @@ class Track(Resource):
    @cache(ttl_sec=5)
    def get(self, track_id):
        decoded_id = decode_with_abort(track_id, ns)
-        return get_single_track(decoded_id, None, ns)
+        return get_single_track(decoded_id, None, ns, exclude_gated=False)


This feels like a small change that could have a big impact to any client flows that are using it and not expecting gated tracks to come back?

This is definitely true, and the only part of this change that makes me somewhat nervous - I need to double check where (if anywhere) we hit this endpoint in our client. I suspect it's nowhere but good to be sure.

schottra · 2024-05-07T15:13:04Z

packages/libs/src/sdk/api/tracks/TracksApi.ts

+    }
+
+    let extraAmount = USDC(extraAmountNumber).value
+    const total = USDC(centPrice / 100.0).value + extraAmount


Every time we write one of these I get a slight bit more anxious that we'll mess one up 😅

schottra · 2024-05-07T15:19:29Z

packages/libs/src/sdk/services/Solana/programs/PaymentRouterClient/PaymentRouterClient.ts

+      'crateTransferInstruction',
+      CreateTransferInstructionSchema
+    )(params)
+    const mint = this.mints[args.mint]


I think it's interesting that some of our utilities/program clients default to a mint and others don't?

none of the clients should? where are you seeing that?

Let me rephrase 😅
It looks like this client expects you to pass a mint and doesn't default to something. But I may have missed where it's default-initialized (and I would assume it defaults to usdc)

I don't think it's desirable for the clients to default to a mint, personally. The apis should be explicit imo

Ah okay. I had thought I saw in other clients we defined here that they did default (Maybe claimable tokens defaulting to waudio?). But I agree with you that they shouldn't, and if I'm imagining things then great!

packages/libs/src/sdk/services/Solana/programs/PaymentRouterClient/PaymentRouterClient.ts

[75169cf] [PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() (#8278) Marcus Pasell [1cef77a] Add image url to response for developer app request (#8387) Raymond Jacobson [72c8171] misc ddex cleanup (#8368) Michelle Brier

[42e9679] [PAY-2995] Fix stream_conditions in saved and library fetch (#8442) Andrew Mendelsohn [ea3beb9] Fix coinflow default (#8443) Raymond Jacobson [64fc7fa] [PAY-2975] Fix mobile-web premium album overflow options (#8441) Reed [ebb531b] [C-4384][C-4383] Small web mobile UI fixes (#8440) Isaac Solo [692df26] [PAY-2966] Add purchase track to mobile collection tracklist overflow (#8429) Reed [0371ee2] re-do placement_hosts field (#8438) Steve Perkins [c6ae1a3] [QA-1268] Fix sentry upload (#8432) Dylan Jeffers [682bfea] [QA-1253] Improve details tile layout (#8433) Dylan Jeffers [1561eba] [QA-1251] Fix short lineup playback issues. (#8402) Dylan Jeffers [8351cba] fix ddex playlists UI (#8435) Michelle Brier [cc2da2c] [PAY-2965, PAY-2968, PAY-2963] Album upload copy fixes; remove 'hidden' option (#8428) Andrew Mendelsohn [7e25f1d] [PAY-2786] Clean up skeletons for collection page (#8427) Andrew Mendelsohn [abc2def] Fix dog ear pt 3 (#8420) JD Francis [0b01e5a] QA-1260: change content title to not say track (#8436) alecsavvy [51733b8] [Web] Implement Remove Manager flows [Manager Mode ] [PAY-2827] (#8413) nicoback2 [c0d1d99] [Web] [Common] Accounts You Manage flows; hook up Accounts Managing You to API (#8301) nicoback2 [92a7937] [QA-1267] Fix blank android tip screen (#8430) Dylan Jeffers [e9a66b1] [QA-1259] Restrict OTP spam (#8426) Dylan Jeffers [102197f] [PAY-2985] Fix squished art in purchase modal (#8423) Reed [9103d7c] [PAY-2960] Change library filter title to Premium (#8422) Reed [7acb56c] Fix web-test by resolving circular import (#8418) Sebastian Klingler [79ffcf4] Revert "Fix dog ear on track page" (#8416) JD Francis [2983a34] Misc $album fixes (#8393) JD Francis [71e5257] Fix dog ear on track page (#8406) JD Francis [212a691] [PAY-2892] Omit albumTrackPrice from data going to backend (#8410) JD Francis [70be1d7] [PAY-2869] Fix play button on mobile collections default state (#8369) Reed [96816ad] [INF-694] Run playwright against local stack (#8407) Sebastian Klingler [51f8462] [PAY-2878] Fix tracks tables right icons (#8412) Reed [c7e9b46] [PAY-2890] Fix hover state on CollectionCard title (#8405) Reed [d45b535] Cleanup user auth config (#8411) Marcus Pasell [a3d41af] [QA-844] Fix misaligned bio links (#8399) Dylan Jeffers [8d2fe53] [PAY-2895] Add native collection card (#8367) Dylan Jeffers [1e1d569] Run SDK gen script as user to allow deletes (#8316) Marcus Pasell [55f127a] [C-4344][C-4352] Fix empty rewards mobile crashing (#8403) Isaac Solo [0b82d23] [PAY-2867] Fix native DMs allowing purchase button to show after purchase (#8392) JD Francis [bcaac19] [PAY-2883] Disable links in purchase modal during purchase (#8388) Reed [535d5d3] [PAY-2865] Mobile web collection page fixes (#8398) Andrew Mendelsohn [11a3837] [QA-1248] Fix search header width (#8381) Dylan Jeffers [359bb4e] [PAY-2902][PAY-2903][PAY-2901] Fix miscellaneous rewards issues (#8395) Saliou Diallo [75169cf] [PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() (#8278) Marcus Pasell [c44d02c] Play with RNTP buffer settings (#8328) Raymond Jacobson [9cca4d5] [PAY-2868] Hide count stats if all zeros (#8396) Andrew Mendelsohn [cb43f96] [PAY-2871] Track table link to track even when it's gated (#8394) Andrew Mendelsohn [c7648c9] Disable failing audius-sdk test (#8386) Marcus Pasell [1254030] [PAY-2773] Remove embed option for premium albums (#8391) Andrew Mendelsohn [ef7c0d0] [PAY-2900] Fix collection upload/edit layout (#8390) Andrew Mendelsohn [f8bfef3] [PAY-2637] Update audio balance on successful rewards claim (#8377) Saliou Diallo [36f1367] [PAY-2893] Fix FilterButton dark mode selection text color (#8389) Reed [a80792e] [PAY-2889] Fix edit collection unlisted value (#8358) Andrew Mendelsohn [415f65b] [PAY-2896][PAY-2908][PAY-2907] Update claim all button text logic (#8376) Saliou Diallo [1ed7651] [PAY-2899] Fix collection header title becoming centered (#8385) Reed [1f7abd7] [PAY-2824] Make Collection play button large (#8384) Reed [270ceaa] [PAY-2886] Fix artist dashboard border radii (#8383) Reed [e2f7dfe] [QA-955] Dismiss keyboard when clicking external link (#8375) Dylan Jeffers [4c86327] [QA-1214] Fix slider border radius (#8379) Dylan Jeffers [ff98977] [QA-1242] Fix play correct track (#8373) Dylan Jeffers [15dee1f] [QA-1239] Fix collection loading state (#8371) Dylan Jeffers [c23549c] [PAY-2722] Add account switcher (#8269) Randy Schott [672a1b1] Bump versions (#8372) Raymond Jacobson [12f0efe] [PAY-2885] Remove require statements on encoded params (#8366) Raymond Jacobson [39dbbb3] Fix mobile lint on main (#8365) Reed [2062cfb] [PAY-2887] Fix purchase notification twitter share copy (#8364) Andrew Mendelsohn [d88f0ab] [PAY-2809] Mobile premium album tracklist UI updates (#8351) Reed [7e3e25b] [PAY-2879] Add purchased pill to mobile albums library (#8363) Andrew Mendelsohn [435c15f] [PAY-2806] Fix offline downloads legacy content node selection (#8362) Andrew Mendelsohn [6485633] QA-1093: fix upload button dark mode (#8359) alecsavvy [009c0e8] [C-4338] Fix $AUDIO available to claim (#8350) Isaac Solo [f411ae5] [PAY-2763] Remove dividers on mobile collection screens (#8353) Reed [7108530] Fix wallet matches check (#8360) Raymond Jacobson [757055a] [PAY-2881] Fix access & sale showing hidden by default (#8352) JD Francis [e5ba7a9] [C-4077] Migrate HelpCallout to Hint (#8349) Dylan Jeffers [50bd5c2] [PAY-2814] Omit favorite and repost buttons for unowned albums (#8357) Andrew Mendelsohn [f8db460] [C-4339] Fix rewards progress label formatting (#8354) Isaac Solo [a057115] [PAY-2888] Fix dog ear positioning (#8356) JD Francis [fdd027c] [PAY-2866] Fix duration showing 0m 0s (#8355) JD Francis [a3797cf] [PAY-2864] Fix progress label for reward on native (#8348) Saliou Diallo [a141f70] [QA-1240] Fix hover state on upload completion (#8341) Raymond Jacobson [deaface] [PAY-2784] Fix premium album upload with download toggle disabled (#8339) JD Francis [8447d73] Fix profile page artist vs user (#8347) Dylan Jeffers

pull-request-size bot added the size/XL label Apr 30, 2024

rickyrombo force-pushed the mjp-sdk-purchase-access branch from c0676af to cf74e69 Compare May 1, 2024 05:56

Base automatically changed from mjp-swagger-to-openapi to main May 2, 2024 01:20

pull-request-size bot added size/XXL and removed size/XL labels May 2, 2024

rickyrombo added 6 commits May 1, 2024 18:54

First iteration of sdk.full.tracks.purchaseStreamAccess()

48d8141

fix purchase type in libs

3b3d9c0

move fixed decimal map

35faead

use userbank or walletadapter based on params

183a69b

hook up payment router client

2be7296

Add temp command for purchasing

86582e4

rickyrombo force-pushed the mjp-sdk-purchase-access branch from 1ffbc7a to 86582e4 Compare May 2, 2024 01:54

pull-request-size bot added size/XL and removed size/XXL labels May 2, 2024

rickyrombo added 13 commits May 2, 2024 00:52

fix claimable tokens client for USDC

f58aa39

allow payment router and compute budget in new relay

cfe301f

add access type to log parsing

7b8cd2a

Fix creation of payment router pda

3f5cbd3

fix config for payment router

1858b38

configure payment router client in web

e3d7f05

support pay extra and fix calculations for splits

df54743

audius-cmd purchase-track w/ pay extra

31b402d

Merge remote-tracking branch 'origin/main' into mjp-sdk-purchase-access

bb5d992

fix import

589973e

Merge remote-tracking branch 'origin/main' into mjp-sdk-purchase-access

0057426

gen sdk

679a5b9

one more import fix

31a7cfe

rickyrombo changed the title ~~First iteration of sdk.full.tracks.purchaseStreamAccess()~~ [PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() May 6, 2024

fix typeerror

73f013c

Move data from v1/full to v1 non-full api for purchase track in SDK (#…

40fd063

…8345)

pull-request-size bot added size/XXL and removed size/XL labels May 6, 2024

rickyrombo marked this pull request as ready for review May 6, 2024 23:05

fix audius-cmd to be non-full

8d1a256

rickyrombo requested review from schottra, dharit-tan and sddioulde May 6, 2024 23:11

rickyrombo assigned raymondjacobson and alecsavvy May 6, 2024

rickyrombo added 2 commits May 6, 2024 16:14

cleaner logs

0407ea1

add changeset

3fde866

raymondjacobson approved these changes May 6, 2024

View reviewed changes

rickyrombo added 3 commits May 6, 2024 17:00

Update payment router program

a89c705

update changeset

154a4a5

remove route usage

f01aa80

rickyrombo added 2 commits May 6, 2024 18:15

fix audius cmd route usage

95d00c2

remove import

052a4ee

schottra approved these changes May 7, 2024

View reviewed changes

CR comments

f6769b3

rickyrombo merged commit 75169cf into main May 8, 2024
14 of 27 checks passed

rickyrombo deleted the mjp-sdk-purchase-access branch May 8, 2024 04:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() #8278

[PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() #8278

rickyrombo commented Apr 30, 2024 •

edited

changeset-bot bot commented Apr 30, 2024 •

edited

audius-infra commented Apr 30, 2024

gitguardian bot commented May 2, 2024 •

edited

audius-infra commented May 6, 2024

audius-infra commented May 6, 2024

raymondjacobson left a comment

audius-infra commented May 7, 2024

audius-infra commented May 7, 2024

schottra left a comment

schottra May 7, 2024

rickyrombo May 8, 2024

schottra May 8, 2024

schottra May 7, 2024

rickyrombo May 7, 2024

schottra May 7, 2024

schottra May 7, 2024

rickyrombo May 7, 2024

schottra May 8, 2024

rickyrombo May 8, 2024

schottra May 8, 2024

[PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() #8278

[PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() #8278

Conversation

rickyrombo commented Apr 30, 2024 • edited

Description

How Has This Been Tested?

changeset-bot bot commented Apr 30, 2024 • edited

🦋 Changeset detected

audius-infra commented Apr 30, 2024

gitguardian bot commented May 2, 2024 • edited

⚠️ GitGuardian has uncovered 10 secrets following the scan of your pull request.

audius-infra commented May 6, 2024

audius-infra commented May 6, 2024

raymondjacobson left a comment

Choose a reason for hiding this comment

audius-infra commented May 7, 2024

audius-infra commented May 7, 2024

schottra left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rickyrombo commented Apr 30, 2024 •

edited

changeset-bot bot commented Apr 30, 2024 •

edited

gitguardian bot commented May 2, 2024 •

edited