Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc ddex cleanup #8368

Merged
merged 2 commits into from
May 7, 2024
Merged

misc ddex cleanup #8368

merged 2 commits into from
May 7, 2024

Conversation

michellebrier
Copy link
Contributor

@michellebrier michellebrier commented May 7, 2024

Description

  • set ddex_app properly on album tracks so they are not editable in the UI
  • use release_date as created_at for albums

this PR includes some old changes to the golang code which we are no longer developing on - plz ignore. didn't feel like reverting

How Has This Been Tested?

will merge to stage and test against local ddex

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: e847d03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented May 7, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9349019 Triggered Generic High Entropy Secret 1fa55dd dev-tools/config.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@michellebrier michellebrier force-pushed the mbrier/proto-1797/ddex-cleanup branch from bf44a05 to e847d03 Compare May 7, 2024 01:24
@@ -667,6 +679,9 @@ def process_playlist_data_event(
playlist_record.updated_at = block_datetime
playlist_record.metadata_multihash = metadata_cid

if is_ddex_signer(params.signer):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to self: still need to list out all ddex keypairs in env variable. We might want to either move this to code, or remove the requirement to know the keypair ahead of time?

@michellebrier michellebrier merged commit 72c8171 into main May 7, 2024
14 checks passed
@michellebrier michellebrier deleted the mbrier/proto-1797/ddex-cleanup branch May 7, 2024 19:19
audius-infra pushed a commit that referenced this pull request May 8, 2024
[75169cf] [PAY-2337] Purchase Tracks via SDK: sdk.tracks.purchase() (#8278) Marcus Pasell
[1cef77a] Add image url to response for developer app request (#8387) Raymond Jacobson
[72c8171] misc ddex cleanup (#8368) Michelle Brier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants