-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc ddex cleanup #8368
misc ddex cleanup #8368
Conversation
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9349019 | Triggered | Generic High Entropy Secret | 1fa55dd | dev-tools/config.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
bf44a05
to
e847d03
Compare
@@ -667,6 +679,9 @@ def process_playlist_data_event( | |||
playlist_record.updated_at = block_datetime | |||
playlist_record.metadata_multihash = metadata_cid | |||
|
|||
if is_ddex_signer(params.signer): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to self: still need to list out all ddex keypairs in env variable. We might want to either move this to code, or remove the requirement to know the keypair ahead of time?
Description
this PR includes some old changes to the golang code which we are no longer developing on - plz ignore. didn't feel like reverting
How Has This Been Tested?
will merge to stage and test against local ddex