Add DP v1 user follows & track/playlist repost/saves #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
approved these changes
Oct 2, 2020
|
|
||
|
|
||
| def get_savers_for_track(save_track_id): | ||
| def get_savers_for_track(args): |
There was a problem hiding this comment.
Michael and I did current_user_id as a separate arg to the fn. Do you like combining that into args instead? Can do that. Let's just be consistent
| @@ -1063,6 +1063,14 @@ def paginate_query(query_obj, apply_offset=True, include_count=False): | |||
| return (modified_query, query_obj.count()) | |||
| return modified_query | |||
|
|
|||
| def add_query_pagination(query_obj, limit, offset, apply_offset=True, include_count=False): | |||
There was a problem hiding this comment.
I like this approach much better. Having methods pull off of the request object makes refactoring pretty hard
jowlee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://www.notion.so/audiusproject/Porting-Client-to-API-9beefcc007ff4242be96124874606227
Item: /users//following & /users//followers
Description
Add user following and follows endpoint to the DP v1 full api with caching
Services
Discovery Provider
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
Delete an option.
How Has This Been Tested?
I ran it locally against the prod snapshot db and compared the query results to the results of the non-v1 api endpoint to check that the fields matched and that the correct users were returned.