Add user track favorites #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
approved these changes
Oct 5, 2020
| Track.is_current == True, | ||
| Save.user_id == user_id, | ||
| Save.is_current == True, | ||
| Save.is_delete == False, |
There was a problem hiding this comment.
Remove is_delete here since you optionally add later?
There was a problem hiding this comment.
The is_delete later is a filter for if it should return deleted tracks that are favorited. If the is_delete on the Save table is true, it mean the user undid the save action, so the track is not saved.
| from src.queries.query_helpers import add_query_pagination, populate_track_metadata, \ | ||
| get_users_by_id, get_users_ids | ||
|
|
||
| def get_full_save_tracks(args): |
There was a problem hiding this comment.
I think we should just call this get_save_tracks or something like that. The "full" vs. "not full" thing is not really part of the query layer so far
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello Card Link
https://trello.com/c/A7BOsv5J/1476-port-the-new-api-into-the-dapp
Description
Adds the user track favorite endpoint so that the client does not need to make multiple requests for this information.
Note: the change to the file discovery-provider/src/queries/get_savers_for_playlist.py fixes a bug I introduced #875
Services
Discovery Provider
Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?
Delete an option.
How Has This Been Tested?
I ran it locally against the Prod snapshot db