Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update creator node middleware for new eth contracts #896

Merged
merged 6 commits into from
Oct 7, 2020
Merged

Update creator node middleware for new eth contracts #896

merged 6 commits into from
Oct 7, 2020

Conversation

dmanjunath
Copy link
Contributor

@dmanjunath dmanjunath commented Oct 7, 2020 •
edited

Trello Card Link

Description

Services

  • Discovery Provider
  • Creator Node
  • Identity Service
  • Libs
  • Contracts
  • Service Commands
  • Mad Dog

Does it touch a critical flow like Discovery indexing, Creator Node track upload, Creator Node gateway, or Creator Node file system?

Delete an option.

  • 馃毃 Yes, this touches the middleware that controls all writes to cnodes

How Has This Been Tested?

Manually tested it by:

  1. Not setting the proper env vars and having it fail
  2. Setting the env vars and have the server listen on the port
  3. Perform writes and make sure the spId and spInfo were valid and made sure secondaries were able to sync
    Please list the unit test(s) you added to verify your changes.

None

@dmanjunath dmanjunath marked this pull request as ready for review October 7, 2020 19:41
hareeshnagaraj
hareeshnagaraj approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@hareeshnagaraj hareeshnagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor q, otherwise LGTM

creator-node/src/middlewares.js

const spId = await libs.ethContracts.ServiceProviderFactoryClient.getServiceProviderIdFromEndpoint(creatorNodeEndpoint)
if (!spId) throw new Error('Cannot get spId for node')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this prevent startup for an unregistered node or just prevent operations from going through? if its the latter we are perfect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will prevent ops from going through. it'll startup just fine

@dmanjunath dmanjunath merged commit 61740fc into master Oct 7, 2020
@dmanjunath dmanjunath deleted the dm-cnode-middleware-new-eth-contracts branch October 7, 2020 20:21
@dmanjunath dmanjunath restored the dm-cnode-middleware-new-eth-contracts branch October 7, 2020 20:33
dmanjunath added a commit that referenced this pull request Oct 7, 2020
@dmanjunath
Revert "Update creator node middleware for new eth contracts (#896)"
6e43e4b 
This reverts commit 61740fc.
@dmanjunath dmanjunath deleted the dm-cnode-middleware-new-eth-contracts branch October 7, 2020 20:35
@dmanjunath dmanjunath mentioned this pull request Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hareeshnagaraj hareeshnagaraj hareeshnagaraj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmanjunath @hareeshnagaraj