Update creator node middleware for new eth contracts (take 2) #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanjunath
changed the title
dmanjunath
changed the title
…o dm-cnode-middleware-new-eth-contracts-2
This reverts commit 46c39e5.
…o dm-cnode-middleware-new-eth-contracts-2
SidSethi
approved these changes
Oct 8, 2020
| const walletAddress = EthereumWallet.fromPrivateKey(privateKeyBuffer).getAddressString() | ||
| if (walletAddress !== config.get('delegateOwnerWallet').toLowerCase()) { | ||
| throw new Error('Invalid delegatePrivateKey/delegateOwnerWallet pair') | ||
| } |
There was a problem hiding this comment.
looks good, curious why not use web3.eth.accounts.privateKeyToAccount (https://web3js.readthedocs.io/en/v1.3.0/web3-eth-accounts.html#privatekeytoaccount)
There was a problem hiding this comment.
this is how identity relay does wallet extraction, so just used the same code honestly
There was a problem hiding this comment.
ye makes sense. clearly it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Built off #896. Needed to bump libs to v1.0.0 in the same PR as those changes because those ETH contract libs wrappers do not exist in our current libs version.
For al other context see old PR #896