Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blue light filters #1065

Merged
merged 7 commits into from Feb 21, 2019

Conversation

Projects
None yet
7 participants
@panicbit
Copy link
Contributor

commented Apr 15, 2018

This change is Reviewable

@panicbit panicbit force-pushed the panicbit:screen_filter branch from 24de844 to d13cde3 Apr 15, 2018

@panicbit

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2018

I just noticed that the LUT gets reset when waking up from standby.

@@ -50,8 +50,12 @@ AccessControlInfo:
# The kernel extension removes svc perms checks, so below is just to avoid a makerom error
Backdoor: 123
KernelSetState: 124
BindInterrupt: 80

This comment has been minimized.

Copy link
@fincs

fincs Apr 15, 2018

Collaborator

This isn't really used, see above comment

do {
u32 pos = idx & 0xFF;

GPU_FB_TOP_COL_LUT_INDEX = pos;

This comment has been minimized.

Copy link
@profi200

profi200 Apr 15, 2018

Contributor

You only need to set the index once. It increases automatically on each write.

@0pen5

0pen5 approved these changes Apr 16, 2018

Repository owner deleted a comment from therealbungus Jul 11, 2018

@TuxSH

This comment has been minimized.

Copy link
Collaborator

commented Aug 1, 2018

Sorry for having not reviewed it yet, will do later

@lagseeing

This comment has been minimized.

Copy link

commented Jan 14, 2019

Did it get reviewed? I want to try this.

@916253

This comment has been minimized.

Copy link
Collaborator

commented Feb 2, 2019

When rebased against the latest commit and built, rosalina's menu no longer opens after setting a filter. Dunno if that happened initially, but its something that needs to be resolved before this can be merged.

@panicbit

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

I'll have a look at it again (but it may take a few weeks).

@TuxSH

This comment has been minimized.

Copy link
Collaborator

commented Feb 21, 2019

Sorry for the very long delay, was busy with other stuff, the code seems totally fine.

Maybe the bug is due to the fact that the menu stack size was not actually bumped (in the array declaration), will check later.

EDIT: yep it's that & I have it working now

Fix menu thread stack overflow
sizeof(menuThreadStack) not matching 0x3000

@TuxSH TuxSH merged commit f437d92 into AuroraWright:master Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.