Changeling Combat Tentacle #10784
Closed
Changeling Combat Tentacle #10784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!review |
Geevies
added
the
Update Wiki
Arrow768
requested changes
Dec 17, 2020
Comment on lines
+247
to
+261
| if(I_DISARM) | ||
| var/obj/item/I = C.get_active_hand() | ||
| if(!I || istype(I, /obj/item/grab)) | ||
| I = C.get_inactive_hand() | ||
| if(I && !istype(I, /obj/item/grab)) | ||
| if(C.unEquip(I)) | ||
| C.visible_message(SPAN_DANGER("[I] is yanked out of [C]'s hand by [src]!"),SPAN_DANGER("A tentacle pulls [I] away from you!")) | ||
| I.throw_at(get_step_towards(H, C), 8, 2, callback = CALLBACK(H, /mob/proc/put_in_any_hand_if_possible, I)) | ||
| return TRUE | ||
| else | ||
| to_chat(firer, SPAN_DANGER("You can't seem to pry [I] out of [C]'s hands!")) | ||
| return FALSE | ||
| else | ||
| to_chat(firer, SPAN_DANGER("[C] has nothing in hand to disarm!")) | ||
| return FALSE |
There was a problem hiding this comment.
I have concerns about that capability, as we removed a lot of the "slap things out of hands" mechanics in the past due to balance issues.
NonQueueingMatt
added
the
Changes Required
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Looks dead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from ParadiseSS13/Paradise#7519
If you want a detailed write-up of how it works, go check that pull request out.