Revert and replace #4127 -- Funk jood, round deux

[skull132]

• Reverts the new chemicals and their effects as implemented in Junkfood Powernerf + Some pain and organ tweaks #4127 due to their unnecessary severity.

• Replaces the reverted mechanics with new mechanics which seek to accomplish a similar thing. Mobs now have an nutrition_attrition_rate factor, which is a multiplier describing how fast they grow hungry. By default, the multiplier is 1. Only eating healthy/chef food will see to it that said multiplier remains at 1.

  Eating bad food, specifically food with nutriment/synthetic in it, will result in the multiplier gradually increasing. This will make the character grow hungry faster, if their only source of sustenance is junk food. The maximum value of the multiplier is up for debate, but it should be no higher than 2. Even that may be stretching it.

  The intent is that, in the worst case scenario, all this'll do is make you go and get food from the vending machines more often. And slightly impact your ability in high stress situations. Nothing severe, like heart damage.

• Also cleans the everliving fuck out of the junk foods file.

TODO:

• Run some maths and figure out the proper rates for increasing the attrition rate and its maximum value.
• Run some searches for remaining notes of junk food compounds.

[BurgerLUA]

Honestly seems wildly inappropriate as I was planning on implementing this, however I was waiting for the mental medication overhaul to finally merge into development which has yet to merge.

[BurgerLUA]

You're likely still going to get bitched at by other players as well. It's clear from the various feedback thread that they don't want any nerfs to junkfood, but buffs instead. You're effectively replacing the devil with just another demon.

[skull132]

Re: inappropriateness. You're free to PR your own alternative, and then we'll see which one is more suitable. I just had this specific idea planned out and wanted to execute. So I did. Doesn't mean this has to be the final form.

And I'm hesitant to use buffs. Buffing is more likely to result in power creep than nerfing certain things. (In general, negative feedback is better.) But I guess we'll see.

[BurgerLUA]

My idea could be implemented alongside yours. Yours add nerfs to junkfood while mine adds buffs to mine. We'll see what happens.

[Arrow768]

Looks good. I would also give other small sweets such as donuts and cookies the NUTRIMENT_BAD

[BurgerLUA]

This is probably highly inappropriate given how im the demon of this sort of thing, but I think the default hunger rate should be slightly slower.

I'm predicting that a lot of people will get hungry really fast and they're going to unironically blame me.

[skull132]

ye I've yet to tweeeeaaak that number. I need a quick reference on how much shit is eaten to regularly fill the foodbar.

So like. Tomorrow:tm: this will be ready, I promise. (Even has the WIP tag atm.)

[BurgerLUA]

Before I tweaked junkfood, I would typically eat between 3-4 meat pies in a shift to keep my nutrition up. I'm just picturing the idea of eating 4-8 meat pies, however I notice that there is no synthetic protein so this doesn't affect Unathi.

[skull132]

HOKAY, QUICK MAFFS.

The idea is that shoving down 400 units (BASE_MAX_NUTRITION) amounts of shit will make you go hungry twice as fast. This comes from the observation that people usually only eat half to two-thirds of their actual max nutrition, so they'll rarely get the actual doubled hunger rate off of 1 feeding.

The way I reached the nutriment_factor value of 0.002, (REM * 4)/BASE_MAX_NUTRITION, is this: every time in digest we get roughly removed = REM * 4. And that's as far as I'm able to explain why I got that equation atm but I suspect it works. 🤔 An integral was used at one point as well, so surely it's correct.

ANYWAYS THIS SHOULD BE FINE AND IS EASILY TWEAKEABLE PR IS READY FOR MERGE.