Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen Food Buffs #4482

Closed
wants to merge 16 commits into from
Closed

Conversation

BurgerLUA
Copy link
Contributor

@BurgerLUA BurgerLUA commented Mar 26, 2018

Nutrient

All nutrients grant a +25 stamina bonus when consumed. The duration of this buff is based on the amount consumed.

Slop and Muck

Blending nutrients will turn the nutrients to slop. This only affects nutrient, not special chemicals like honey, flour, milk, and other chemicals. Slop fills you up, but causes a detriment to stamina (-25) and stamina regeneration for a variable amount of seconds.

Blending meat will turn it into muck, which does the same thing as slop.

Sugar

Consuming too much sugar can lead to sugar crashes, which causes a flat stamina loss (-20) for a variable duration based on the amount of sugar consumed. Sugar crashes only occur if the most sugar you've had in your system at one time exceeds 10 units.

Sugar is now a nutrient. It can damage antmen now, so be aware.

Junkfood

Junkfood now contains various amounts of sugar, muck, and slop, save for SkrellSnacks which are expensive and healthy. Junkfood won't kill you anymore, but just gives you less stamina.

Syringes

In order to prevent meme exploits, food can no longer be extracted by syringes. Uses the biogenerator vitamin pills if you really have to powergame for nutrients, smh.

@LordFowl
Copy link
Contributor

LordFowl commented Mar 26, 2018

This replaces a dumb system with a retarded system. There is no reason to use reagents like this. This implementation is perhaps in every way inferior to just nerfing junk food without actually fucking killing people, as proposed in #4481

@LordFowl LordFowl added Review Required Update Wiki The PR changes something that needs to be reflected on the wiki. labels Mar 26, 2018
@LordFowl LordFowl added this to the April Update milestone Mar 26, 2018
@LordFowl LordFowl added the Feedback Required The PR requires a feedback topic and feedback on the forum. label Mar 26, 2018
@BurgerLUA
Copy link
Contributor Author

BurgerLUA commented Mar 26, 2018

I highly disagree and think that this is a huge, pointless overreaction that is somehow more whiny and more arbitrary than the combined crying of every sincere ooc cheapshot of junk food that I've witnessed while playing.

The most I'll do is make it so that the buffs are attached to nutrients with flavor tags instead, but completely remove the ability to use syringes on food because that's dumb in the first place.

@BurgerLUA BurgerLUA changed the title [WIP] Botany Food + Kitchen Food Buffs [WIP] Kitchen Food Buffs Mar 27, 2018
@BurgerLUA
Copy link
Contributor Author

PR is reworked and fundamentally changed.

@@ -27,6 +27,9 @@
var/metabolism_min = 0.01 //How much for the medicine to be present in the system to actually have an effect.
var/list/conflicting_reagents //Reagents that conflict with this medicine, and cause adverse effects when in the blood.

var/list/container_whitelist = list()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not make = list() vars on commonly instanced types, like reagents.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove the feature entirely.

@BurgerLUA BurgerLUA changed the title [WIP] Kitchen Food Buffs Kitchen Food Buffs Mar 29, 2018
@@ -672,6 +672,7 @@
#include "code\game\mecha\working\working.dm"
#include "code\game\modifiers\modifiers.dm"
#include "code\game\modifiers\modifiers_chem.dm"
#include "code\game\modifiers\modifiers_food.dm"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exactly do we need another modifier system?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just another file?

@@ -5171,3 +5152,13 @@
/obj/item/weapon/reagent_containers/food/snacks/corn_dog/Initialize()
. = ..()
reagents.add_reagent("protein", 3)

/obj/item/weapon/reagent_containers/food/snacks/meatloaf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why exactly those two do not start with any reagents of their own?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the slop (and other chemicals) it's made with is transferred into the food.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If someone spawns one of those via other means, they will be empty, which should not really happen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed.

@Keinto
Copy link

Keinto commented Mar 31, 2018

Why not revert to how it used to be before this entire ordeal and JUST REMOVE MOST vending machines on the station?

I can't think of a simpler way to make the kitchen more appealing to the crew and at the same time not make the game dumber with debuffs and buffs from eating food in a 2 hour shift.

@BurgerLUA
Copy link
Contributor Author

Vending machines need to exist to provide a quick, easy way to fill your hunger. It's convenience food, however this update makes it so that real food will be a better alternative than the current food without punishing people who eat junkfood too much.

@BurgerLUA BurgerLUA changed the title Kitchen Food Buffs [DNM for a bit] Kitchen Food Buffs Apr 6, 2018
@BurgerLUA
Copy link
Contributor Author

Okay. This is now meant to work alongside the #4481 update.

Some additions:

  • There is now synthetic protein. It doesn't make sense that junk food companies would skimp on the pastry but still provide quality meat.
  • Slop and Muck are now positive, but not as good as nutrients. All junk food now contains synth nutrients or synth protein.

@BurgerLUA BurgerLUA changed the title [DNM for a bit] Kitchen Food Buffs Kitchen Food Buffs Apr 6, 2018
@skull132
Copy link
Contributor

skull132 commented Apr 8, 2018

Since this is a conflict of interest for me, note that the following is the summary opinion of the other devs. /disclaimer

Anywho, they are either against it for the reason that it's still a bit excessive, or that it is now unnecessary considering #4481. So, at present time, this will be closed. If it turns out that #4481 is not on the spot, then this PR may be reconsidered at a later date.

@skull132 skull132 closed this Apr 8, 2018
@BurgerLUA
Copy link
Contributor Author

@skull132

please have my bad children

@BotBOREALIS BotBOREALIS removed the Update Wiki The PR changes something that needs to be reflected on the wiki. label Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feedback Required The PR requires a feedback topic and feedback on the forum. Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants