New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kitchen Food Buffs #4482
Kitchen Food Buffs #4482
Conversation
This replaces a dumb system with a retarded system. There is no reason to use reagents like this. This implementation is perhaps in every way inferior to just nerfing junk food without actually fucking killing people, as proposed in #4481 |
I highly disagree and think that this is a huge, pointless overreaction that is somehow more whiny and more arbitrary than the combined crying of every sincere ooc cheapshot of junk food that I've witnessed while playing. The most I'll do is make it so that the buffs are attached to nutrients with flavor tags instead, but completely remove the ability to use syringes on food because that's dumb in the first place. |
PR is reworked and fundamentally changed. |
@@ -27,6 +27,9 @@ | |||
var/metabolism_min = 0.01 //How much for the medicine to be present in the system to actually have an effect. | |||
var/list/conflicting_reagents //Reagents that conflict with this medicine, and cause adverse effects when in the blood. | |||
|
|||
var/list/container_whitelist = list() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not make = list()
vars on commonly instanced types, like reagents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove the feature entirely.
@@ -672,6 +672,7 @@ | |||
#include "code\game\mecha\working\working.dm" | |||
#include "code\game\modifiers\modifiers.dm" | |||
#include "code\game\modifiers\modifiers_chem.dm" | |||
#include "code\game\modifiers\modifiers_food.dm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exactly do we need another modifier system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just another file?
@@ -5171,3 +5152,13 @@ | |||
/obj/item/weapon/reagent_containers/food/snacks/corn_dog/Initialize() | |||
. = ..() | |||
reagents.add_reagent("protein", 3) | |||
|
|||
/obj/item/weapon/reagent_containers/food/snacks/meatloaf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why exactly those two do not start with any reagents of their own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the slop (and other chemicals) it's made with is transferred into the food.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone spawns one of those via other means, they will be empty, which should not really happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was fixed.
Why not revert to how it used to be before this entire ordeal and JUST REMOVE MOST vending machines on the station? I can't think of a simpler way to make the kitchen more appealing to the crew and at the same time not make the game dumber with debuffs and buffs from eating food in a 2 hour shift. |
Vending machines need to exist to provide a quick, easy way to fill your hunger. It's convenience food, however this update makes it so that real food will be a better alternative than the current food without punishing people who eat junkfood too much. |
Okay. This is now meant to work alongside the #4481 update. Some additions:
|
Since this is a conflict of interest for me, note that the following is the summary opinion of the other devs. /disclaimer Anywho, they are either against it for the reason that it's still a bit excessive, or that it is now unnecessary considering #4481. So, at present time, this will be closed. If it turns out that #4481 is not on the spot, then this PR may be reconsidered at a later date. |
please have my bad children |
Nutrient
All nutrients grant a +25 stamina bonus when consumed. The duration of this buff is based on the amount consumed.
Slop and Muck
Blending nutrients will turn the nutrients to slop. This only affects nutrient, not special chemicals like honey, flour, milk, and other chemicals. Slop fills you up, but causes a detriment to stamina (-25) and stamina regeneration for a variable amount of seconds.
Blending meat will turn it into muck, which does the same thing as slop.
Sugar
Consuming too much sugar can lead to sugar crashes, which causes a flat stamina loss (-20) for a variable duration based on the amount of sugar consumed. Sugar crashes only occur if the most sugar you've had in your system at one time exceeds 10 units.
Sugar is now a nutrient. It can damage antmen now, so be aware.
Junkfood
Junkfood now contains various amounts of sugar, muck, and slop, save for SkrellSnacks which are expensive and healthy. Junkfood won't kill you anymore, but just gives you less stamina.
Syringes
In order to prevent meme exploits, food can no longer be extracted by syringes. Uses the biogenerator vitamin pills if you really have to powergame for nutrients, smh.