Reported issue fixes #573
Merged
Reported issue fixes #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed firedoor hatches drawing ontop of office/blast shutters when both are on the same tile Drones can now bump open windoors added attack logs for meteor impacts slightly increased volume of meteor shield impact sound fixed meteor event end announcements
| @@ -142,6 +143,9 @@ | |||
| !istype(A,/obj/machinery/field_generator) && \ | |||
| prob(detonation_chance)) | |||
| explosion(loc, power, power + power_step, power + power_step * 2, power + power_step * 3, 0) | |||
| msg_admin_attack("Meteor exploded at coords <[x],[y],[z]>") | |||
There was a problem hiding this comment.
Please change all of these <[x],[y],[z]> references to this: (<a href='?_src_=holder;adminplayerobservecoodjump=1;X=[x];Y=[y];Z=[z]'>JMP</a>)
skull132
added
Changes Required
|
Doesn't satisfy my report on #565 . Read the last reply. Also, one required change noted in the line comments. |
|
Disregard my post about 565, it appears to be BYOND client related and works fine on 510 build. The coords need fixing, tho. |
| @@ -131,7 +131,7 @@ | |||
|
|
|||
| if (T)//We have a double safety check on T to prevent runtime errors | |||
| meteor_shield_impact_sound(T, shieldsoundrange) | |||
| msg_admin_attack("Meteor impacted energy field at coords <[x],[y],[z]>") | |||
| msg_admin_attack("Meteor impacted energy field at coords (<a href='?_src_=holder;adminplayerobservecoodjump=1;X=[x];Y=[y];Z=[z]'><[x],[y],[z]>JUMPTO</a>)") | |||
There was a problem hiding this comment.
I told you specifically to use JMP. Every other jump link ingame is formatted like that.
Closed
NanakoAC
added
Review Required
and removed
Changes Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed hatch overlay not being cut when a firedoor opens
Fixed firedoor hatches drawing ontop of office/blast shutters when both are on the same tile
Drones can now bump open windoors
added attack logs for meteor impacts
slightly increased volume of meteor shield impact sound
fixed meteor event end announcements