Skip to content
This repository has been archived by the owner on Mar 5, 2018. It is now read-only.

Improvement - prefix variables with a namespace like "uikit" #345

Open
elisechant opened this issue Sep 5, 2016 · 4 comments
Open

Improvement - prefix variables with a namespace like "uikit" #345

elisechant opened this issue Sep 5, 2016 · 4 comments
Labels

Comments

@elisechant
Copy link

It's difficult to include ui-kit in existing projects because of the collision of Sass variables which are global. To avoid collisions prefix ui-kit variables with some namespace.

ie.

$base-z-index: 0;
$base-border-radius: 3px;
$tiny-border-radius: 1px;

might be

$uikit-base-z-index: 0;
$uikit-base-border-radius: 3px;
$uikit-tiny-border-radius: 1px;
@elisechant elisechant changed the title Improvement - prefix variables with a namespace like "govau" Improvement - prefix variables with a namespace like "uikit" Sep 5, 2016
@TrebBrennan
Copy link
Contributor

TrebBrennan commented Sep 5, 2016

Sensible idea, I like it.
I vote for au as the prefix; to remind us who we're making this for ;)

@petronbot
Copy link
Contributor

Great suggestion @elisechant, the only thing for us to do is decide what the prefix should be

  1. $govau-uikit-
  2. $govau-
  3. $au-

Or something else?

@nathf
Copy link
Contributor

nathf commented Sep 5, 2016

FWIW from my last PR I had added $gov-ui-kit-image-base-url for this very reason.

https://github.com/AusDTO/gov-au-ui-kit/blob/develop/assets/sass/_variables.scss#L12

@klepas klepas added the roadmap label Sep 7, 2016
@klepas
Copy link
Contributor

klepas commented Sep 7, 2016

Added to Jira under DESIGN-443.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants