Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for permanent server #617

Open
bumbummen99 opened this issue May 22, 2022 · 3 comments
Open

Add test for permanent server #617

bumbummen99 opened this issue May 22, 2022 · 3 comments

Comments

@bumbummen99
Copy link
Collaborator

Coverage Status

Coverage decreased (-6.8%) to 87.918% when pulling 0bac556 on dns-mocking into 01700ea on v3.

Originally posted by @coveralls in #616 (comment)

@bumbummen99
Copy link
Collaborator Author

Tests currently, as intended, do not query any actual server. We should also query an actual server that is kinda permanent or run the associated codepaths in some other way.

@bumbummen99
Copy link
Collaborator Author

It might be best practice to actually install and start a server right in our CI, that way we do not rely on any uncontrollable factors.

@Austinb
Copy link
Owner

Austinb commented Mar 28, 2023

Circling back to this the only real way to do this for every test set is to spin up a fake server that responds with the data from the test sets. Trying to spin up an actual game server for each game would be time consuming and full of issue in the long term. The only benefit to doing this is to be able to test the actual query classes making remote calls. Not sure we need to do this for all game types just a few common ones within A2S.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants