Fixes exception when StringLength decorates non-string member #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aivascu
force-pushed
the
stringlength-fix
branch
2 times, most recently
from
72dded6
to
c589029
Compare
aivascu
force-pushed
the
stringlength-fix
branch
from
c589029
to
e6aafbe
Compare
aivascu
changed the title
vbreuss
pushed a commit
to Testably/Testably.Abstractions
that referenced
this pull request
Feb 22, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [AutoFixture.Xunit2](https://togithub.com/AutoFixture/AutoFixture) | nuget | minor | `4.17.0` -> `4.18.0` | --- ### Release Notes <details> <summary>AutoFixture/AutoFixture</summary> ### [`v4.18.0`](https://togithub.com/AutoFixture/AutoFixture/releases/tag/v4.18.0): Version 4.18.0 #### What's Changed - Fixed failing build due to outdated dependencies by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1287 - Added mention of copy constructors to terminating error by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1294 - Added MyGet preview badge to readme by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1301 - Added Issue and PR templates by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1310 - Updated readme FAKE build engine URL by [@​MichaelNel](https://togithub.com/MichaelNel) in [AutoFixture/AutoFixture#1347 - Added support for NSubstitute 5.0 by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1383 - Fixed exception when StringLength decorates non-string member by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1366 - Fixed failing request for default max length attribute by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1384 #### New Contributors - [@​MichaelNel](https://togithub.com/MichaelNel) made their first contribution in [AutoFixture/AutoFixture#1347 **Full Changelog**: AutoFixture/AutoFixture@v4.17.0...v4.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNDguMCIsInVwZGF0ZWRJblZlciI6IjM0LjE0OC4wIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
renovate bot
added a commit
to cythral/brighid-discord-adapter
that referenced
this pull request
Apr 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [AutoFixture.AutoNSubstitute](https://togithub.com/AutoFixture/AutoFixture) | nuget | minor | `4.17.0` -> `4.18.0` | --- ### Release Notes <details> <summary>AutoFixture/AutoFixture</summary> ### [`v4.18.0`](https://togithub.com/AutoFixture/AutoFixture/releases/tag/v4.18.0): Version 4.18.0 ##### What's Changed - Fixed failing build due to outdated dependencies by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1287 - Added mention of copy constructors to terminating error by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1294 - Added MyGet preview badge to readme by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1301 - Added Issue and PR templates by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1310 - Updated readme FAKE build engine URL by [@​MichaelNel](https://togithub.com/MichaelNel) in [AutoFixture/AutoFixture#1347 - Added support for NSubstitute 5.0 by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1383 - Fixed exception when StringLength decorates non-string member by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1366 - Fixed failing request for default max length attribute by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1384 ##### New Contributors - [@​MichaelNel](https://togithub.com/MichaelNel) made their first contribution in [AutoFixture/AutoFixture#1347 **Full Changelog**: AutoFixture/AutoFixture@v4.17.0...v4.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cythral/brighid-discord-adapter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to cythral/brighid-commands
that referenced
this pull request
Apr 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [AutoFixture.NUnit3](https://togithub.com/AutoFixture/AutoFixture) | nuget | minor | `4.17.0` -> `4.18.0` | --- ### Release Notes <details> <summary>AutoFixture/AutoFixture</summary> ### [`v4.18.0`](https://togithub.com/AutoFixture/AutoFixture/releases/tag/v4.18.0): Version 4.18.0 #### What's Changed - Fixed failing build due to outdated dependencies by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1287 - Added mention of copy constructors to terminating error by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1294 - Added MyGet preview badge to readme by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1301 - Added Issue and PR templates by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1310 - Updated readme FAKE build engine URL by [@​MichaelNel](https://togithub.com/MichaelNel) in [AutoFixture/AutoFixture#1347 - Added support for NSubstitute 5.0 by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1383 - Fixed exception when StringLength decorates non-string member by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1366 - Fixed failing request for default max length attribute by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1384 #### New Contributors - [@​MichaelNel](https://togithub.com/MichaelNel) made their first contribution in [AutoFixture/AutoFixture#1347 **Full Changelog**: AutoFixture/AutoFixture@v4.17.0...v4.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cythral/brighid-commands). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to cythral/brighid-commands
that referenced
this pull request
Apr 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [AutoFixture.AutoNSubstitute](https://togithub.com/AutoFixture/AutoFixture) | nuget | minor | `4.17.0` -> `4.18.0` | --- ### Release Notes <details> <summary>AutoFixture/AutoFixture</summary> ### [`v4.18.0`](https://togithub.com/AutoFixture/AutoFixture/releases/tag/v4.18.0): Version 4.18.0 #### What's Changed - Fixed failing build due to outdated dependencies by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1287 - Added mention of copy constructors to terminating error by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1294 - Added MyGet preview badge to readme by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1301 - Added Issue and PR templates by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1310 - Updated readme FAKE build engine URL by [@​MichaelNel](https://togithub.com/MichaelNel) in [AutoFixture/AutoFixture#1347 - Added support for NSubstitute 5.0 by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1383 - Fixed exception when StringLength decorates non-string member by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1366 - Fixed failing request for default max length attribute by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1384 #### New Contributors - [@​MichaelNel](https://togithub.com/MichaelNel) made their first contribution in [AutoFixture/AutoFixture#1347 **Full Changelog**: AutoFixture/AutoFixture@v4.17.0...v4.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cythral/brighid-commands). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to cythral/brighid-discord-adapter
that referenced
this pull request
Apr 6, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [AutoFixture.NUnit3](https://togithub.com/AutoFixture/AutoFixture) | nuget | minor | `4.17.0` -> `4.18.0` | --- ### Release Notes <details> <summary>AutoFixture/AutoFixture</summary> ### [`v4.18.0`](https://togithub.com/AutoFixture/AutoFixture/releases/tag/v4.18.0): Version 4.18.0 #### What's Changed - Fixed failing build due to outdated dependencies by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1287 - Added mention of copy constructors to terminating error by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1294 - Added MyGet preview badge to readme by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1301 - Added Issue and PR templates by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1310 - Updated readme FAKE build engine URL by [@​MichaelNel](https://togithub.com/MichaelNel) in [AutoFixture/AutoFixture#1347 - Added support for NSubstitute 5.0 by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1383 - Fixed exception when StringLength decorates non-string member by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1366 - Fixed failing request for default max length attribute by [@​aivascu](https://togithub.com/aivascu) in [AutoFixture/AutoFixture#1384 #### New Contributors - [@​MichaelNel](https://togithub.com/MichaelNel) made their first contribution in [AutoFixture/AutoFixture#1347 **Full Changelog**: AutoFixture/AutoFixture@v4.17.0...v4.18.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/cythral/brighid-discord-adapter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zNC4xIiwidXBkYXRlZEluVmVyIjoiMzUuMzQuMSJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[StringLength]attributeClosed issues
fixes #1365
Checklist