Resolves #467 by relaying non-seeded requests. #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,5 +129,23 @@ public void CreateWithCorrectlyTypedSeededRequestWithNullSeedReturnsCorrectResul | |||
| Assert.Equal(expectedResult, result); | |||
| // Teardown | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void CreateWithCorrectlyTypedRequestReturnsCorrectResult() | |||
There was a problem hiding this comment.
Doesn't this test slightly overspecify the implementation details?
If we didn't have this test, wouldn't it leaves us more flexibility with regards to future refactoring?
There was a problem hiding this comment.
Yes, that test was superseded by these scenario tests introduced in 28bb833. I'll remove it.
The SeededFactory<T> class did not handle non-seeded requests for the specified type T. This resulted in an ObjectCreationException when AutoFixture had to create specimens to populate properties, fields and parameters of type T.
ecampidoglio
force-pushed
the
467-create-value-from-seed
branch
from
28bb833
to
c7ce7d2
Compare
|
Thank you for your contribution! It's now live as AutoFixture 3.36.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
SeededFactory<T>class to relay also non-seeded requests forTto the custom factory function passing the default value ofTas a seed. This is to solve #467.