We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Original Author: @dkirillov
The readConfigFile function is able to read both YAML and JSON file. Using a switch-statement it picks the correct class to unmarshal data with.
readConfigFile
This switch statement can be removed in favor of using just YAML (from gopkg.in/yaml.v3) to unmarshal things.
gopkg.in/yaml.v3
Reduce and make cleaner code.
N/A
An attempt was made, however, started to look like a rabbit hole with the errors that would come up (see screenshot below).
It should be possible, just would need to have a separate PR for clarity.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Original Author: @dkirillov
Summary
The
readConfigFile
function is able to read both YAML and JSON file. Using a switch-statement it picks the correct class to unmarshal data with.This switch statement can be removed in favor of using just YAML (from
gopkg.in/yaml.v3
) to unmarshal things.Motivation
Reduce and make cleaner code.
Describe alternatives you've considered
N/A
Additional context
An attempt was made, however, started to look like a rabbit hole with the errors that would come up (see screenshot below).
It should be possible, just would need to have a separate PR for clarity.
The text was updated successfully, but these errors were encountered: