Don't show undefined users (bug 666704)

AutomatedTester · Jun 23, 2011 · 0fe0a36 · 0fe0a36
1 parent cdb9de7
commit 0fe0a36
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/media/js/zamboni/editors.js b/media/js/zamboni/editors.js
@@ -126,13 +126,18 @@ function initReviewActions() {
     var addon_id = $('#addon').attr('data-id');
     function check_currently_viewing() {
         $.post('/en-US/editors/review_viewing', {'addon_id': addon_id}, function(d){
-            $current = $('.currently_viewing_warning');
-            $current.toggle(d.is_user != 1);
-
-            var title = format(gettext('{name} was viewing this page first.'), {name: d.current_name});
-            $current_div = $current.filter('div');
-            $current_div.find('strong').remove();
-            $current_div.prepend($('<strong>', {'text': title}));
+            var show = d.is_user != 1 && typeof d.current_name != "undefined",
+                       $current = $('.currently_viewing_warning');
+
+            $current.toggle(show);
+
+            if(show) {
+              var title = format(gettext('{name} was viewing this page first.'),
+                                         {name: d.current_name});
+              $current_div = $current.filter('div');
+              $current_div.find('strong').remove();
+              $current_div.prepend($('<strong>', {'text': title}));
+            }
 
             setTimeout(check_currently_viewing, d.interval_seconds * 1000);
         });