Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed WP CLI create-terms-for-posts if no co-authors found #420

Merged
merged 7 commits into from
Jun 17, 2017
Merged

Fixed WP CLI create-terms-for-posts if no co-authors found #420

merged 7 commits into from
Jun 17, 2017

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented May 30, 2017 •
edited
Loading

As per #410, script was stopping after no co-authors was found. Now script should display error message and continue to the next post.

Rebecca Hum added 6 commits May 29, 2017 19:39
Removed duplicate left join for optimization
6e7da2b
Merge branch 'master' of https://github.com/Automattic/Co-Authors-Plus
1387ae1
Fixed WP CLI create-terms-for-posts if no co-authors found
f759744 
Script was stopping after no co-authors was find. Now script will
display an error message and continue to the next post.
Revert "Fixed WP CLI create-terms-for-posts if no co-authors found"
76c59ef 
This reverts commit f759744.
Revert "Removed duplicate left join for optimization"
9f8a1d5 
This reverts commit 6e7da2b.
Fixed WP CLI create-terms-for-posts if no co-authors found
68bcb6e 
Script was stopping after no co-authors was find. Now script will
display an error message and continue to the next post.
@rebeccahum rebeccahum requested a review from trepmal May 30, 2017 21:56
trepmal
trepmal requested changes Jun 1, 2017
View reviewed changes
Copy link
Contributor

@trepmal trepmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually don't want to continue to the next post in this context. The function create_terms_for_posts() is looking for the posts with no terms in order to assign them.

@rebeccahum
Copy link
Contributor Author

rebeccahum commented Jun 1, 2017 •
edited
Loading

Removed it.

@philipjohn philipjohn added this to the 3.3 milestone Jun 17, 2017
@philipjohn philipjohn merged commit 7bdae3c into Automattic:master Jun 17, 2017
@philipjohn
Copy link
Contributor

@trepmal Given the comments on #410 can you clarify whether this is necessary or we should revert the merge? Thanks!

rebeccahum pushed a commit that referenced this pull request Mar 26, 2019
@philipjohn
Merge pull request #420 from rebeccahum/cli-create-terms-for-posts
bd6aab1 
Fixed WP CLI create-terms-for-posts if no co-authors found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepmal trepmal trepmal approved these changes

Assignees

@trepmal trepmal

@0nko 0nko

Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@rebeccahum @philipjohn @trepmal @0nko