Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search values to the job_manager_get_listings_custom_filter_text filter #845

Merged
merged 1 commit into from
Feb 16, 2017

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Dec 20, 2016

Adds an array of the search terms to be passed to the message filter so they can be included in any modified output.

@spencerfinnell
Copy link
Contributor

Not exactly sure when it this was introduced but the message now collects a bunch of info then overrides it at the end with a single string. I actually prefer this approach.

$message = sprintf( _n( 'Search completed. Found %d matching record.', 'Search completed. Found %d matching records.', $jobs->post_count, 'wp-job-manager' ), $jobs->post_count );

The values added to the message filter make all of this reproducible if needed, but we see the majority of people wanting to remove the message altogether, so the simpler message is preferred anyway.

@dbtlr
Copy link
Contributor

dbtlr commented Feb 15, 2017

It was introduced as part of 1.25.2 -- 1.25.1...1.25.2#diff-364b7a907b7409cda9ed115f463f23ba

LGTM

@dbtlr dbtlr added this to the 1.25.3 milestone Feb 15, 2017
@dbtlr dbtlr merged commit 02bf581 into master Feb 16, 2017
@dbtlr dbtlr deleted the kraftbj-patch-2 branch February 16, 2017 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants