Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The way to check if header title is active #815

Closed
mtomas7 opened this issue Sep 1, 2015 · 2 comments
Closed

The way to check if header title is active #815

mtomas7 opened this issue Sep 1, 2015 · 2 comments

Comments

@mtomas7
Copy link
Contributor

mtomas7 commented Sep 1, 2015

The comment section of inc/custom-header.php says:

// Has the text been hidden?

and then uses this way to check it:

if ( 'blank' === $header_text_color ) :

On the other hand Twenty Fifteen uses:

if ( ! display_header_text() ) :

Should we go with the 2015 method?

@karmatosed
Copy link
Contributor

I think that could be a good idea. Have you got a patch you could create for us to review?

@mtomas7
Copy link
Contributor Author

mtomas7 commented Sep 17, 2015

Unfortunately I'm not so familiar with GIT, so at this point I can only suggest something, but I do not have knowledge how to use GIT to prepare patches.

I hope someone can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants