Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n and code layout #1101

Merged
merged 2 commits into from
Jun 9, 2017

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Apr 2, 2017

This PR addresses two separate issues, but is pulled as one as the fixes would otherwise cause merge conflicts.

Commit 1:

Fixes missing /* translators */ comments for translatable text strings containing placeholders.

Commit 2:

Fixes infractions against the For associative arrays, values should start on a new line. code style rule and changes the code layout of the nested functions where this occurred for optimal readability.

Ref: https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#indentation

@jrfnl jrfnl mentioned this pull request Apr 2, 2017
@davidakennedy davidakennedy merged commit 812fefd into Automattic:master Jun 9, 2017
@jrfnl jrfnl deleted the feature/i18n-and-code-layout branch June 10, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants