Soft-deprecate AMP_Base_Sanitizer::get_body_node() #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
update/soft-deprecate-get-body-node
branch
from
63c530b
to
cbc0ae5
Compare
kienstra
approved these changes
May 10, 2018
There was a problem hiding this comment.
Approved
Hi @westonruter,
Good idea to soft-deprecate get_body_node() , and it's nice how you added it to the Changelog.
|
Include in 0.7.1? Hi @westonruter, |
|
Thanks, @westonruter! |
|
This topic might also be related to this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no need to hard-deprecate this method with a warning. And it may be useful still to have this method to get the
bodywhen thehtmlelement is not desired.See https://wordpress.org/support/topic/amp_base_sanitizerget_body/