Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding images to AMP carousel gallery #1187

Merged
merged 1 commit into from
May 31, 2018
Merged

Fix adding images to AMP carousel gallery #1187

merged 1 commit into from
May 31, 2018

Conversation

westonruter
Copy link
Member

Fixes issue which occurs when manipulating DOM elements that are part of a live list.

Amends #1121.

See https://github.com/Automattic/amp-wp/pull/1121/files/201654fa66c1c0dec3f7336c3dd2bf382d39e73e#r191989786

Copy link
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@westonruter westonruter merged commit 64de118 into develop May 31, 2018
@westonruter westonruter deleted the fix/gallery branch May 31, 2018 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants