Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change to utils.strlen in 0.3.7 #157

Closed
adrianosmond opened this issue Nov 18, 2021 · 1 comment
Closed

Breaking change to utils.strlen in 0.3.7 #157

adrianosmond opened this issue Nov 18, 2021 · 1 comment

Comments

@adrianosmond
Copy link

Previous to 0.3.7 utils.strlen converted anything passed into it into a string while stripping it via
var stripped = ("" + str).replace(code,'');

As of 0.3.7, str is passed directly to stripAnsi:
var stripped = stripAnsi(str);

This means that anything that isn't a string is being passed into it it now breaks in a way that it didn't in 0.3.6. I came across this because @lingui/cli is passing numbers into a table

@adrianosmond
Copy link
Author

Apologies. This is a duplicate of #152. I'm closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant