Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Dash vs. Underscore #1

Closed
davewhitley opened this issue Jan 3, 2014 · 2 comments
Closed

Dash vs. Underscore #1

davewhitley opened this issue Jan 3, 2014 · 2 comments

Comments

@davewhitley
Copy link
Contributor

Any reason why we are using a hyphen here instead of an underscore like it's used in the Field Guide?

(in colors.scss)

screen shot 2014-01-03 at 3 36 00 pm

@MichaelArestad
Copy link
Contributor

Yep. I think we need to get on the same page with our prefixes across both class names and variables. We had a brief discussion about this in Skype.

I would prefer reserving underscore for name-spacing and use hyphens for spaces.

Example:

.wpcom_awesome-logo {
    color: $light-blue;
}

I know the current color file is already in place and if it's super painful to change, it's no big deal going back. I do, however, think we should get on the same page with name-spacing.

@MichaelArestad
Copy link
Contributor

Went full-on BEM this update.

Details in README.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants