Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Blocks: test/remove widgets in Legacy Widget block #21069

Closed
27 tasks done
arcangelini opened this issue Sep 14, 2021 · 15 comments
Closed
27 tasks done

Widget Blocks: test/remove widgets in Legacy Widget block #21069

arcangelini opened this issue Sep 14, 2021 · 15 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Extra Sidebar Widgets [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@arcangelini
Copy link
Contributor

arcangelini commented Sep 14, 2021

Impacted plugin

Jetpack

What

Test and remove Jetpack widgets that are not working inside the Legacy Widget block

How

With the recent release of the new widget block editor came a new block that displays legacy widgets within a block. This allows users to continue using the original Jetpack widgets even after converting to the new block editor.

The problem is that many of the widgets do not work properly inside the legacy block. We need to test all of the current widgets inside the legacy block and remove the ones that already have viable block replacements. Legacy Widget block documentation

This issue is only addressing the availability of the widget inside the Legacy Widget block. I will create another GH issue to tackle the transform. I think these should be separate because they vary in importance.

Widgets

  • Instagram
  • Twitter timeline
  • Social Icons
  • Akismet
  • Authors
  • Blog Stats
  • Blog Subscriptions
  • Contact Info & Map
  • Cookies and Consent
  • Display WordPress Posts
  • Facebook Page
  • Flickr
  • GeoTagged Posts
  • Goodreads
  • Google Translate
  • Gravatar
  • Internet Defense Leage
  • Mailchimp Subscription Popup
  • Mailerlite
  • Milestone
  • Music Player
  • My Community
  • Pay with PayPal
  • Blogs I Follow
  • Posts I Like
  • RSS links
  • Upcoming Events
@arcangelini arcangelini added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Widget Visibility Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". labels Sep 14, 2021
@arcangelini arcangelini self-assigned this Sep 14, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Sep 14, 2021
@simison
Copy link
Member

simison commented Sep 15, 2021

Nice, thanks! I appreciate the organization here.

Milestone seems a8c only?

Let's also review if there's a (close enough) block equivalent and deprecate widget if there is. I'd also be curious for insights that would help improve blocks or block patterns, so that we could deprecate some more widgets.

Search, RSS links, mailchimp, Instagram, etc

@jeherve
Copy link
Member

jeherve commented Sep 15, 2021

Milestone seems a8c only?

No, it's available for everyone.

Let's also review if there's a (close enough) block equivalent and deprecate widget if there is.

+1. Although I wouldn't deprecrate right away, I would suggest setting up transforms for those blocks first.

@simison
Copy link
Member

simison commented Sep 15, 2021

How would transforms change the experience around deprecations? Deprecating would mean that new customers can't insert deprecated widgets anymore, and those don't need transforms obviously. Previously inserted widgets would continue functioning in editors, but for those transforms seem more like a "really nice have", but not critical?

I could very well miss something so curious for your thoughts!

@jeherve
Copy link
Member

jeherve commented Sep 15, 2021

I may be wrong with my expectations, but since their legacy widgets would be transformed into blocks, folks would learn to use the block directly the next time around, instead of trying to insert a legacy widget that would get transformed later?

It's definitely not critical, but I see it as a way to help people discover those new blocks.

@arcangelini
Copy link
Contributor Author

Instagram widget - PR r231968-wpcom

@arcangelini
Copy link
Contributor Author

Authors widget

This widget is working well in the Legacy Block and we do not have a block to replace it with just yet. Checking it off the list, for now, we may want to look at building a viable replacement block.

@arcangelini
Copy link
Contributor Author

Goodreads

This widget is working well in the Legacy Block and we do not have a block to replace it with just yet. Checking it off the list, for now, we may want to look at building a viable replacement block.

@aisajib
Copy link

aisajib commented Sep 26, 2021

This is almost certainly not the right place to bring it up, but I really wanted to note this somewhere and perhaps one of you can point me in the right direction. :)

In the original list of legacy widgets to be removed, I noticed that "Text" and "Images" are not there. I was looking for them because I've been trying to look for a solution to this forum post.

They basically want to show an image with text below, and control the visibility of that widget. We know that the visibility option is only available on legacy blocks. So our suggestion of using the Image + Paragraph block isn't useful as the user can't control the visibility. Would one of you know if it's a sad Christmas here or if there is another way to achieve this that I haven't thought of yet?

We already suggested inserting the "widget" (using Image and Paragraph blocks) into the actual page content instead of at the sidebar, but the user doesn't like how it looks, so they want it on the actual sidebar.

Thank you and apologies for bringing this here. :disappear:

@arcangelini
Copy link
Contributor Author

Hey @aisajib thanks for pointing this out. I am going to make a P2 post this week summarizing what we have done so far with the Jetpack widget ⇢ block transforms and hopefully, that will offer a place to discuss some of the particulars that people are running into.

As for the visibility button, I think the best way to respond at this point is with CSS. All blocks should have the CSS Class option under Show More SettingsAdvanced with the exception of the Legacy Widget block. Moving forward, I am not sure if there is a plan to incorporate the Visibility option into the blocks I think that would be something Gutenberg would be working on?

I do know there is a new Widget Group block that has been released (only on WPCOM right now, but should be public with the next major release). If visibility was something that would be incorporated, I would imagine it to fit into this block? Just a thought though... WordPress/gutenberg#33881

@simison
Copy link
Member

simison commented Sep 27, 2021

@aisajib @arcangelini visibility feature is almost done for the blocks, so they should be able to use image+text blocks soon. Just a couple small issues to sort out, listed at #20731 (comment)

@arcangelini
Copy link
Contributor Author

Social Icons - PR

@arcangelini
Copy link
Contributor Author

Total list of ALL WordPress.com widgets investigations - p1633288426167100-slack-C029HCKPXP0

@arcangelini
Copy link
Contributor Author

Cookies & Consent Banner - working with no exact block to replace with yet

Facebook Page - working with no exact block to replace with yet

Flickr Photos - working with no exact block to replace with yet

Google Translate - working with no exact block to replace with yet

Gravatar - working with no exact block to replace with yet

Gravatar Profile - working with no exact block to replace with yet

Internet Defense League - working with no exact block to replace with yet

@arcangelini
Copy link
Contributor Author

Apex team is now responsible for widgets. I believe most of these are taken care of but I could be wrong. I will let @yansern and @ivan-ottinger decide what to do with this from here.

@arcangelini arcangelini removed their assignment Jan 15, 2022
@ivan-ottinger
Copy link
Contributor

ivan-ottinger commented Jan 17, 2022

Thanks for the ping, Tony.

Below is the summary of the remaining widgets and our plans with them. The project spreadsheet with details can be found over here: p1633288426167100-slack-C029HCKPXP0.

Of course, if anyone of you have any comments / suggestions / other opinion on what should happen with specific widgets, feel free to let us know. We will be glad to discuss further. :)


Widgets we plan to keep for the time being

The following widgets don't have an equivalent block available and provide unique feature.

  • Display WordPress Posts: There's a similar Query Loop block available, but the Display WordPress Posts widget allows users to display a list of posts from other WordPress sites as well.
  • RSS Links: There's the RSS block available, but it displays the actual links to blog posts coming from the selected RSS feed. On the other hand, the RSS Links widget displays links to the blog's RSS feeds.
  • Upcoming Events: The widget allows users do display a list of events from chosen calendar. We don't have a similar block available.
  • Music Player: The existing Audio block does not give the option to create a playlist that is unique to the Music Player widget.
  • Blog Stats: We don't have a similar block available. It can be built in the future (panfyZ-8L-p2#comment-504).
  • Top Posts & Pages: We don't have a similar block available. It can be built in the future (panfyZ-8L-p2#comment-504).

Widgets we plan to deprecate (details are in pdf5j4-7f-p2)

  • Mailchimp Subscription Popup
  • My Community
  • Posts I Like
  • Blogs I Follow
  • Internet Defense League

I am also updating the description of this issue so it is in sync with the project spreadsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Extra Sidebar Widgets [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

5 participants