Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review permission checks for both plugin and wpcom APIs #24445

Open
kangzj opened this issue May 19, 2022 · 0 comments
Open

Review permission checks for both plugin and wpcom APIs #24445

kangzj opened this issue May 19, 2022 · 0 comments
Labels
[Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster.
Projects
Jetpack Search - Standalone

Comments

@kangzj
Copy link
Contributor

kangzj commented May 19, 2022 •
edited
Loading

Previously we had several issues regarding permission checks, user token, blog token etc. For example: #24099

We probably want to check all REST API our plugin provided have the right access control or using the right token to authenticate:

#24099

Also we need to check the WPCOM endpoints:

  • sites/{site}/jetpack_search/plan
  • sites/{site}/jetpack_search/stats
  • etc

More information: p9dueE-55u#comment-7999

The outcome of the task would be whether they are okay, if not we'll need to file issues.
@kangzj kangzj created this issue from a note in Jetpack Search - Standalone (To do) May 19, 2022
@kangzj kangzj changed the title Check permission checks for both plugin and wpcom APIs Review permission checks for both plugin and wpcom APIs May 19, 2022
@kangzj kangzj added [Feature] Search For all things related to Search [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Package] Search Contains core Search functionality for Jetpack and Search plugins labels May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Search For all things related to Search [Package] Search Contains core Search functionality for Jetpack and Search plugins [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster.
Projects
Jetpack Search - Standalone
  
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kangzj