-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: Fix search on private WordPress.com-on-Atomic sites #24099
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
4f6869e
to
0161451
Compare
0161451
to
2844cff
Compare
@jsnmoon Yep I think so, this is a bug - I guess I didn't anticipate a local user isn't necessary a WPCOM user in the previous PR. |
Hi @jsnmoon, could you please share more details about how to create a WoA site? I'm not sure how I set up one - should I use the sandbox, a ephemeral site or sth else? |
The consumer-centric way would be to spin up a regular WordPress.com site, purchase a Pro plan, and install a plugin on it. I'll share the more dev-friendly method (internal to a8c) privately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. It works for me 👍
Fixes #24197.
Changes proposed in this Pull Request:
Fixes search on private WordPress.com-on-Atomic (WoA) sites by signing the requests with a blog token instead of a user token.
Also changes the local API URL to the one provided by the search package instead of the one provided by the Jetpack plugin.
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
Note: This PR is only testable by a12s.
/?s=
. Ensure that the search interface works as expected.https://wordpress.com/settings/general/
and change site visibility to Private.