De-Fusion: Likes

[sdixon194]

Impacted plugin

Jetpack

What

Likes

How

This one might be good to save for last.

"$plugin_root/modules/likes.php"                        => "$wpcom_root/wp-content/mu-plugins/likes/jetpack-likes.php",
"$plugin_root/modules/likes/jetpack-likes-settings.php" => "$wpcom_root/wp-content/mu-plugins/likes/jetpack-likes-settings.php",
"$plugin_root/modules/likes/style.css"                  => "$wpcom_root/wp-content/mu-plugins/likes/jetpack-likes.css",
"$plugin_root/_inc/jquery.jetpack-resize.js"            => "$wpcom_root/wp-content/js/jquery/jquery.jetpack-resize.js",
// This file was removed from Jetpack, and will be removed from wpcom once it's synced.
//"$plugin_root/_inc/jquery.inview.js"                  => "$wpcom_root/wp-content/js/jquery/jquery.inview.js",
"$plugin_root/_inc/postmessage.js"                      => "$wpcom_root/wp-content/js/postmessage.js",
"$plugin_root/modules/likes/post-count.js"              => "$wpcom_root/wp-content/mu-plugins/likes/post-count.js",
"$plugin_root/modules/likes/post-count-jetpack.js"      => "$wpcom_root/wp-content/mu-plugins/likes/post-count-jetpack.js",
"$plugin_root/modules/likes/queuehandler.js"            => "$wpcom_root/wp-content/mu-plugins/likes/queuehandler.js",

[sdixon194]

$plugin_root/modules/likes.php is pretty out of sync.

These files seem to be removed from Jetpack but still exist on dotcom. I'm wondering if they can just be removed.

• jquery.jetpack-resize.js
• jquery.inview.js
• postmessage.js

everything else is in sync.

[anomiex]

Looking at likes.php, Jetpack missed

• r170101-wpcom
  • Although the widget doesn't seem to be hidden by CSS on Jetpack sites...
• D10021-code
• D10955-code (note the affected code had been moved to a different file in Add Comment Likes module #7175)
• D25102-code and some followups
• D66115-code (although part was later done in Show like button if disabled in global settings but enabled in post-meta. Also show reblog button when like button is hidden on wpcom. #21022)

and wpcom missed

• a8a0845
• 5ad7a72
• e6bb90a
• b9afd07
• 75698bb
• 0431ff7
• Likes: move settings below other notification settings #4987
• Likes: Prevent a PHP notice when there is no $post object #5988
• Add Comment Likes module #7175
• Minify more JS #8329
• Various: Use wp_resource_hints #16305
• Parts of PHPCS: Like module #19250

[anomiex]

So #27008 will bring in all the stuff Jetpack missed except for r170101-wpcom, since the justification given there for deleting it on wpcom doesn't seem to apply to Jetpack.

[anomiex]

After further testing and investigation, this seems like a huge mess and the best option seems to be to just let the two continue going their separate ways.

• p9dueE-64G-p2
• Jetpack: Likes: "De-Fusion" by removing wpcom code paths #27062
• D90671-code